Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rewrite Interpolation section and add Interpolation example #25170

Closed
wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Jul 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add new document for Interpolation. This is part of the Template Syntax break out.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Special thanks to @trotyl and @brandonroberts :)

aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
aio/content/guide/interpolation.md Outdated Show resolved Hide resolved

Other notable differences from JavaScript syntax include:

* No support for the bitwise operators `|` and `&`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use such as, there're also other bitwise operators like ^, ~, <<, >>, <<<, >>> not being supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview c96cc39 at https://pr25170-c96cc39.ngbuilds.io/.

1 similar comment
@mary-poppins
Copy link

You can preview c96cc39 at https://pr25170-c96cc39.ngbuilds.io/.

@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Aug 1, 2018
@kapunahelewong kapunahelewong changed the title [WIP] docs: add Interpolation doc and example docs: add Interpolation doc and example Aug 1, 2018
@mary-poppins
Copy link

You can preview 87e876c at https://pr25170-87e876c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4ec0e67 at https://pr25170-4ec0e67.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8851a79 at https://pr25170-8851a79.ngbuilds.io/.

@kapunahelewong
Copy link
Contributor Author

@jenniferfell the interpolation info is in the Template Syntax doc. Ready for your review.

@mary-poppins
Copy link

You can preview 2192926 at https://pr25170-2192926.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3f517d4 at https://pr25170-3f517d4.ngbuilds.io/.

@kapunahelewong kapunahelewong changed the title docs: add Interpolation doc and example docs: rewrite Interpolation section and add Interpolation example Aug 7, 2018
aio/content/examples/interpolation/example-config.1.json Outdated Show resolved Hide resolved
aio/content/examples/interpolation/example-config.json Outdated Show resolved Hide resolved
aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
aio/content/guide/interpolation.md Outdated Show resolved Hide resolved
aio/content/guide/template-syntax.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview fcbd511 at https://pr25170-fcbd511.ngbuilds.io/.

@kapunahelewong kapunahelewong changed the title docs: rewrite Interpolation section and add Interpolation example [WIP]docs: rewrite Interpolation section and add Interpolation example Sep 13, 2018
@mary-poppins
Copy link

You can preview 900c4b8 at https://pr25170-900c4b8.ngbuilds.io/.

@AndrewKushnir
Copy link
Contributor

@kapunahelewong thanks for submitting a PR.

It looks like there was additional commit and a rebase after last approval/review. @brandonroberts could you please have a quick look and add "merge" label back?

Thank you.

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 11, 2019
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Jan 11, 2019
@brandonroberts brandonroberts removed the request for review from a team January 11, 2019 01:26
@brandonroberts brandonroberts added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Jan 11, 2019

However, interpolation is a special syntax that Angular converts into a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are usually in the form of **Note:** Note text for alerts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Good to know. I can fix in a follow up PR or when I break them out so I don't cause any more hiccups. 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kapunahelewong
Copy link
Contributor Author

@AndrewKushnir Oops! Thanks for your patience. :)

@ocombe
Copy link
Contributor

ocombe commented Jan 11, 2019

@IgorMinar I checked the API data for this PR (https://api.github.com/repos/angular/angular/pulls/25170/reviews), I think that the problem is that there are 39 reviews, and by default a page of results is limited to 30 results, so that's why some of the results are ignored and it doesn't get the correct count.
I'll fix the bot

@IgorMinar
Copy link
Contributor

IgorMinar commented Jan 11, 2019 via email

@ocombe ocombe added target: patch This PR is targeted for the next patch release and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Jan 11, 2019
@ocombe
Copy link
Contributor

ocombe commented Jan 11, 2019

fixed

kyliau pushed a commit to kyliau/angular that referenced this pull request Jan 11, 2019
petebacondarwin pushed a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@kapunahelewong kapunahelewong deleted the interpolation branch June 20, 2019 18:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants