New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rewrite Interpolation section and add Interpolation example #25170
Conversation
aio/content/guide/interpolation.md
Outdated
|
||
Other notable differences from JavaScript syntax include: | ||
|
||
* No support for the bitwise operators `|` and `&` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use such as
, there're also other bitwise operators like ^
, ~
, <<
, >>
, <<<
, >>>
not being supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
ed64607
to
87e876c
Compare
You can preview c96cc39 at https://pr25170-c96cc39.ngbuilds.io/. |
1 similar comment
You can preview c96cc39 at https://pr25170-c96cc39.ngbuilds.io/. |
You can preview 87e876c at https://pr25170-87e876c.ngbuilds.io/. |
87e876c
to
4ec0e67
Compare
You can preview 4ec0e67 at https://pr25170-4ec0e67.ngbuilds.io/. |
You can preview 8851a79 at https://pr25170-8851a79.ngbuilds.io/. |
8851a79
to
2192926
Compare
@jenniferfell the interpolation info is in the Template Syntax doc. Ready for your review. |
You can preview 2192926 at https://pr25170-2192926.ngbuilds.io/. |
2192926
to
3f517d4
Compare
You can preview 3f517d4 at https://pr25170-3f517d4.ngbuilds.io/. |
3f517d4
to
f5ede98
Compare
68d121d
to
88dc017
Compare
88dc017
to
fcbd511
Compare
You can preview fcbd511 at https://pr25170-fcbd511.ngbuilds.io/. |
You can preview 900c4b8 at https://pr25170-900c4b8.ngbuilds.io/. |
@kapunahelewong thanks for submitting a PR. It looks like there was additional commit and a rebase after last approval/review. @brandonroberts could you please have a quick look and add "merge" label back? Thank you. |
|
||
However, interpolation is a special syntax that Angular converts into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are usually in the form of **Note:** Note text
for alerts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Good to know. I can fix in a follow up PR or when I break them out so I don't cause any more hiccups. 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@AndrewKushnir Oops! Thanks for your patience. :) |
@IgorMinar I checked the API data for this PR (https://api.github.com/repos/angular/angular/pulls/25170/reviews), I think that the problem is that there are 39 reviews, and by default a page of results is limited to 30 results, so that's why some of the results are ignored and it doesn't get the correct count. |
Thanks Olivier!
…On Fri, Jan 11, 2019 at 12:13 AM Olivier Combe ***@***.***> wrote:
@IgorMinar <https://github.com/IgorMinar> I checked the API data for this
PR, I think that the problem is that there are 39 reviews, and by default a
page of results is limited to 30 results, so that's why some of the results
are ignored and it doesn't get the correct count.
I'll fix the bot
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25170 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6JWNjeeqgFKWQxFqVWL1gc97GoGSks5vCEeWgaJpZM4Vkkk0>
.
|
fixed |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Add new document for Interpolation. This is part of the Template Syntax break out.
Does this PR introduce a breaking change?
Other information
Special thanks to @trotyl and @brandonroberts :)