feat: typescript 3 support #25275

alan-agius4 · 2018-08-03T07:24:43Z

This adds support for TypeScript 3.0.

Notes:

for the time being tsickle doesn't support TypeScript 3.0
3 unit tests from program_spec.ts have been xit. Anyone willing to help. Please feel free.

jotatoledo · 2018-08-05T08:40:45Z

integration/typings_test_ts30/package.json

@@ -0,0 +1,31 @@
+{
+  "name": "angular-integration",
+  "description": "Assert that users with TypeScript 2.9 can type-check an Angular application",


TypeScript 3.0?

yes, nice catch

googlebot · 2018-08-09T23:24:16Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

alan-agius4 · 2018-08-10T04:13:58Z

I confirm, I signed it.

Thanks Igor

IgorMinar · 2018-08-10T04:37:05Z

Please ignore the cla bot. I rebased and updated your pr. Still looking at at failing tests.

…

On Thu, Aug 9, 2018, 9:14 PM Alan Agius ***@***.***> wrote: I confirm, I sign it. Thanks Igor — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#25275 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6OcLyKNd4paN9jhMxBgDLsvC5ZdWks5uPQiLgaJpZM4VtgO-> .

googlebot · 2018-08-10T15:44:40Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-08-10T16:00:19Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

JoostK · 2018-08-10T16:58:16Z

@alan-agius4 they still seem to fail in Travis

googlebot · 2018-08-10T22:23:56Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

IgorMinar · 2018-08-10T22:25:32Z

@alan-agius4 still looking into it.

googlebot · 2018-08-11T00:17:03Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

matsko · 2018-08-27T18:12:17Z

@alan-agius4 can you please rebase and push again. Master on CircleCI should be ok now.

alan-agius4 · 2018-08-27T18:16:38Z

@matsko I m trying too, but I am getting Already up to date.

IgorMinar · 2018-08-27T20:31:05Z

caretaker note: presubmit results are green I just can't push the status right now.

matsko · 2018-08-27T22:15:52Z

Sorry @alan-agius4 it still needs one last rebase. It looks like the auto-squashing of the fixup! commits is failing. Can you please interactively rebase and do the squashing yourself in the interactive mode? This way we can merge this without the git autosquash bugging out.

Just do git rebase HEAD~10 and combine the fixup commits into the main commits.

Thank you.

googlebot · 2018-08-27T23:05:37Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

alan-agius4 · 2018-08-27T23:06:42Z

@matsko, rebase with fixups done.

Need to a googler to verify the CLA.

…der bazel

In tsc 3.0 the check that enables program structure reuse in tryReuseStructureFromOldProgram has changed and now uses identity comparison on arrays within CompilerOptions. Since we recreate the options on each incremental compilation, we now fail this check. After this change the default set of options is reused in between incremental compilations, but we still allow options to be overriden if needed.

mary-poppins · 2018-08-27T23:21:35Z

You can preview 007865c at https://pr25275-007865c.ngbuilds.io/.

IgorMinar · 2018-08-27T23:22:19Z

I rebased one more time since there were more conflicts due to upstream merges.

googlebot · 2018-08-27T23:22:28Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mary-poppins · 2018-08-27T23:29:12Z

You can preview 463194a at https://pr25275-463194a.ngbuilds.io/.

…der bazel (#25275) PR Close #25275

…on (#25275) In tsc 3.0 the check that enables program structure reuse in tryReuseStructureFromOldProgram has changed and now uses identity comparison on arrays within CompilerOptions. Since we recreate the options on each incremental compilation, we now fail this check. After this change the default set of options is reused in between incremental compilations, but we still allow options to be overriden if needed. PR Close #25275

PR Close angular#25275

…der bazel (angular#25275) PR Close angular#25275

…on (angular#25275) In tsc 3.0 the check that enables program structure reuse in tryReuseStructureFromOldProgram has changed and now uses identity comparison on arrays within CompilerOptions. Since we recreate the options on each incremental compilation, we now fail this check. After this change the default set of options is reused in between incremental compilations, but we still allow options to be overriden if needed. PR Close angular#25275

angular-automatic-lock-bot · 2019-09-14T01:51:52Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 3, 2018

alan-agius4 closed this Aug 3, 2018

alan-agius4 reopened this Aug 4, 2018

alan-agius4 changed the title ~~feat: typescript 3 support~~ feat: typescript 3 support (WIP) Aug 4, 2018

jotatoledo reviewed Aug 5, 2018

View reviewed changes

alan-agius4 changed the title ~~feat: typescript 3 support (WIP)~~ feat: typescript 3 support Aug 5, 2018

IgorMinar self-assigned this Aug 8, 2018

IgorMinar self-requested a review August 8, 2018 17:21

IgorMinar added the target: major This PR is targeted for the next major release label Aug 8, 2018

googlebot added cla: no and removed cla: yes labels Aug 9, 2018

IgorMinar added cla: yes and removed cla: no labels Aug 10, 2018

googlebot added cla: no and removed cla: yes labels Aug 10, 2018

IgorMinar added cla: yes and removed cla: no labels Aug 10, 2018

googlebot added cla: no and removed cla: yes labels Aug 11, 2018

IgorMinar added cla: yes and removed cla: no labels Aug 11, 2018

IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 27, 2018

angular deleted a comment from googlebot Aug 27, 2018

googlebot added cla: no and removed cla: yes labels Aug 27, 2018

alan-agius4 and others added 3 commits August 27, 2018 16:20

feat: add TypeScript 3 support

af5be63

test(compiler-cli): fix the incremental ngc tests so that they run un…

2dbcc7c

…der bazel

IgorMinar added cla: yes and removed cla: no labels Aug 27, 2018

matsko closed this in 5653fad Aug 28, 2018

matsko pushed a commit that referenced this pull request Aug 28, 2018

test(compiler-cli): fix the incremental ngc tests so that they run un…

ab32ac6

…der bazel (#25275) PR Close #25275

albohlabs mentioned this pull request Aug 28, 2018

Feat: Add support for TypeScript 3 #25200

Closed

alan-agius4 deleted the feature_ts-3 branch September 19, 2018 09:08

Barbiero mentioned this pull request Sep 27, 2018

Change @angular/common/http methods to use unknown #26150

Closed

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

feat: add TypeScript 3 support (angular#25275)

4bd3562

PR Close angular#25275

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

test(compiler-cli): fix the incremental ngc tests so that they run un…

9215c84

…der bazel (angular#25275) PR Close angular#25275

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: typescript 3 support #25275

feat: typescript 3 support #25275

alan-agius4 commented Aug 3, 2018 •

edited

jotatoledo Aug 5, 2018

alan-agius4 Aug 5, 2018

googlebot commented Aug 9, 2018

alan-agius4 commented Aug 10, 2018 •

edited

IgorMinar commented Aug 10, 2018 via email

googlebot commented Aug 10, 2018

googlebot commented Aug 10, 2018

JoostK commented Aug 10, 2018

googlebot commented Aug 10, 2018

IgorMinar commented Aug 10, 2018

googlebot commented Aug 11, 2018

matsko commented Aug 27, 2018

alan-agius4 commented Aug 27, 2018

IgorMinar commented Aug 27, 2018

matsko commented Aug 27, 2018

googlebot commented Aug 27, 2018

alan-agius4 commented Aug 27, 2018

mary-poppins commented Aug 27, 2018

IgorMinar commented Aug 27, 2018

googlebot commented Aug 27, 2018

mary-poppins commented Aug 27, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

feat: typescript 3 support #25275

feat: typescript 3 support #25275

Conversation

alan-agius4 commented Aug 3, 2018 • edited

jotatoledo Aug 5, 2018

Choose a reason for hiding this comment

alan-agius4 Aug 5, 2018

Choose a reason for hiding this comment

googlebot commented Aug 9, 2018

alan-agius4 commented Aug 10, 2018 • edited

IgorMinar commented Aug 10, 2018 via email

googlebot commented Aug 10, 2018

googlebot commented Aug 10, 2018

JoostK commented Aug 10, 2018

googlebot commented Aug 10, 2018

IgorMinar commented Aug 10, 2018

googlebot commented Aug 11, 2018

matsko commented Aug 27, 2018

alan-agius4 commented Aug 27, 2018

IgorMinar commented Aug 27, 2018

matsko commented Aug 27, 2018

googlebot commented Aug 27, 2018

alan-agius4 commented Aug 27, 2018

mary-poppins commented Aug 27, 2018

IgorMinar commented Aug 27, 2018

googlebot commented Aug 27, 2018

mary-poppins commented Aug 27, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

alan-agius4 commented Aug 3, 2018 •

edited

alan-agius4 commented Aug 10, 2018 •

edited