Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): support ng-container at the root of a view with delayed insertion #25329

Conversation

pkozlowski-opensource
Copy link
Member

This PR handles the following case:

<ng-template #tpl>
  <ng-container>
    content
  </ng-container>
</ng-template>

where #tpl is not inserted into the DOM immediately. This might happen where the TemplateRef.createEmbeddedView(...) is called to create view instance and then this view is inserted (or not) at the later time.

@pkozlowski-opensource pkozlowski-opensource added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Aug 6, 2018
@mary-poppins
Copy link

You can preview 7bd6b3f at https://pr25329-7bd6b3f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ac14ae3 at https://pr25329-ac14ae3.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 6, 2018
@mhevery
Copy link
Contributor

mhevery commented Aug 6, 2018

@kara kara closed this in 3355502 Aug 6, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants