New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): support ng-container inside another ng-container #25346
fix(ivy): support ng-container inside another ng-container #25346
Conversation
You can preview 8de4940 at https://pr25346-8de4940.ngbuilds.io/. |
let grandParent = getParentLNode(parent as LElementContainerNode); | ||
while (grandParent.tNode.type === TNodeType.ElementContainer) { | ||
grandParent = getParentLNode(grandParent as LElementContainerNode); | ||
} | ||
if (grandParent.tNode.type === TNodeType.View) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the canInsertNativeNode
counterpart, we account for grandParent
being null
here. Is that relevant here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, since we've already checked (in the canInsertNativeNode
) that it can be inserted so there should be a render parent somewhere above.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR takes care of the following cases wrt to
<ng-container>
:Nested
<ng-container>
:Nested
<ng-container>
in a view with delayed insertion:Changes in the code are minimal so most of the diff is about tests.