feat(ivy): implement TestBed #25369

vicb · 2018-08-07T23:07:02Z

The goal of this PR is to implement the TestBed for IVY so that tests relying on it could be run either for the ViewEngine or for the Render3 without having to modify the test file.

Use bazel test <target> to execute a test targeting the ViewEngine
Use bazel test <target> --define=compile=jit to execute a test targeting the Render3

This PR also add a spec for the TestBed itself which can be run for either the ViewEngine or Render3:

bazel test packages/core/test:test runs the ViewEngine tests
bazel test packages/core/test:test --define=compile=jit runs the Render3 tests

Note that in the second case (Render3) there will be quite some errors due to the fact that much more specs than the TestBed spec are executed. You might want to fdescribe the TestBed spec for now when adding functionality.

Notes

TestBed now point to either _Render3TestBed or _ViewEngineTestBed depending on if IVY is respectively enabled (--define=compile=jit) or not.
_Render3TestBed and _ViewEngineTestBed do not implement a common interface / extends a base class because it would be hard to do with the static methods. However they have a compatible interface and the code would not compile w/o errors if it was not the case.

Todo

see #25389

Recommended usage

Because of the high number of failing tests using IVY, the best for now is to fdescribe a test suite (ie NgFor spec and execute the spec against IVY bazel test packages/common/test:test[_web] and fix the errors by

fixing bugs in IVY,
implementing missing features in IVY,
fixing the _Render3TestBed, DebugContext or DebugNode

JoostK · 2018-08-08T17:00:08Z

packages/core/src/render3/instructions.ts

@@ -201,6 +201,11 @@ export function getCreationMode(): boolean {
 */
 let viewData: LViewData;

+export function getViewData(): LViewData {
+  // top level variables should not be exported for performance reasons (PERF_NOTES.md)
+  return viewData;


This is exported already through _getViewData

mhevery · 2018-08-08T23:23:24Z

packages/core/src/render3/component_ref.ts

    const isInternalRootView = rootSelectorOrNode === undefined;

    const rendererFactory =
-        ngModule ? ngModule.injector.get(RendererFactory2) : domRendererFactory3;
+        (ngModule ? wrapRendererFactory2(ngModule.injector.get(RendererFactory2)) :


This needs be done in a way where we don't pull in the TestBed codebase into production application.

const wrapper = ngModule.injector.get(WraperToken, Optional); let render2 = ngModule.injector.get(RendererFactory2); if (wrapper) { renderer2 = wrapper(render2); }

mhevery · 2018-08-08T23:31:31Z

packages/core/src/render3/ng_dev_mode.ts

@@ -31,13 +30,12 @@ declare global {
    rendererRemoveNode: number;
    rendererCreateComment: number;
  }
+  const ngDebugRenderer: boolean;


revert whole file.

mhevery · 2018-08-08T23:33:48Z

packages/core/src/render3/jit/module_testbed.ts

@@ -0,0 +1,258 @@
+/**


move to @angular/core/testing.

mhevery · 2018-08-08T23:35:30Z

packages/core/src/render3/jit/util.ts

+/**
+ * Base interface to resolve `@Component`, `@Directive`, `@Pipe` and `@NgModule`.
+ */
+export interface Resolver<T> { resolve(type: Type<any>): T|null; }


move to @angular/core/testing

mhevery · 2018-08-08T23:37:36Z

packages/core/test/application_ref_integration_spec.ts

-export function defineNgModule({bootstrap}: {bootstrap?: Type<any>[]}):
-    NgModuleDef<any, any, any, any> {
-  return ({ bootstrap: bootstrap || [], } as any);
+if (ivyEnabled) {


change to ivyEnabled && describe(... so that we don't have every line changed by you.

mhevery · 2018-08-09T00:00:11Z

tools/public_api_guard/core/testing.d.ts

-export declare function resetFakeAsyncZone(): void;
-
-export declare class TestBed implements Injector {
+export declare class _ViewEngineTestBed implements Injector {


Change name to TestBedViewEngine or TestBed2 so that order is preserved.

mhevery · 2018-08-09T00:02:45Z

tools/public_api_guard/core/testing.d.ts

+/** @experimental */
+export declare function resetFakeAsyncZone(): void;
+
+export declare const TestBed: typeof _Render3TestBed | typeof _ViewEngineTestBed;


_Render3TestBed seems to be missing from export. Also rename to TestBed3

vicb · 2018-08-09T23:57:04Z

http://test/OCL:208134388:BASE:208134428:1533859006974:d084de57

gregmagolan · 2018-08-10T18:38:33Z

@vicb I looked at the failing integration/bazel test and it looks like the @angular/core bundle is now depending on the @angular/compiler bundle which it wasn't before.

(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('rxjs'), require('rxjs/operators'), require('@angular/compiler')) :
    typeof define === 'function' && define.amd ? define('@angular/core', ['exports', 'rxjs', 'rxjs/operators', '@angular/compiler'], factory) :
    (factory((global.ng = global.ng || {}, global.ng.core = {}),global.rxjs,global.rxjs.operators,global.ng.compiler));

That bundle is not included in the devserver since it was an AOT build. Is @angular/core now supposed to depend on @angular/compiler?

gregmagolan · 2018-08-10T18:40:03Z

The bundles included in the devserver in the integration/bazel test are defined in integration/bazel/BUILD.bazel:

ANGULAR_TESTING = [
    "node_modules/@angular/*/bundles/*-testing.umd.js",
    # We use AOT, so the compiler and the dynamic platform-browser should be
    # visible only in tests
    "node_modules/@angular/compiler/bundles/*.umd.js",
    "node_modules/@angular/platform-browser-dynamic/bundles/*.umd.js",
]

filegroup(
    name = "angular_bundles",
    srcs = glob(
        ["node_modules/@angular/*/bundles/*.umd.js"],
        exclude = ANGULAR_TESTING,
    ),
)

gregmagolan · 2018-08-10T18:41:29Z

For reference, the core bundle on angular master master looks like this:

(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('rxjs'), require('rxjs/operators')) :
    typeof define === 'function' && define.amd ? define('@angular/core', ['exports', 'rxjs', 'rxjs/operators'], factory) :
    (factory((global.ng = global.ng || {}, global.ng.core = {}),global.rxjs,global.rxjs.operators));
``` (only depending on rxjs)

mary-poppins · 2018-08-13T17:22:59Z

You can preview 89f7b91 at https://pr25369-89f7b91.ngbuilds.io/.

mary-poppins · 2018-08-13T17:29:54Z

You can preview bb6fc89 at https://pr25369-bb6fc89.ngbuilds.io/.

mary-poppins · 2018-08-13T17:48:23Z

You can preview d2d5100 at https://pr25369-d2d5100.ngbuilds.io/.

mary-poppins · 2018-08-13T21:15:19Z

You can preview 106703a at https://pr25369-106703a.ngbuilds.io/.

mary-poppins · 2018-08-13T22:23:00Z

You can preview d084e80 at https://pr25369-d084e80.ngbuilds.io/.

@mhevery

@mhevery approved the changed (which apparently do not dismiss prior "requesting changes")

vicb · 2018-08-14T04:06:04Z

Waiting for g3 to go green before re-presubmitting.

vicb · 2018-08-14T14:53:34Z

http://test/OCL:208134388:BASE:208646256:1534258381779:adbe2370

mary-poppins · 2018-08-14T14:59:23Z

You can preview 460d984 at https://pr25369-460d984.ngbuilds.io/.

PR Close #25369

PR Close angular#25369

angular-automatic-lock-bot · 2019-09-13T23:21:14Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 7, 2018

vicb added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy and removed cla: yes labels Aug 7, 2018

googlebot added the cla: yes label Aug 7, 2018

vicb force-pushed the 07-r3tb branch 3 times, most recently from ff03264 to ecb9d18 Compare August 8, 2018 03:14

vicb changed the title ~~feat(ivy): implement TestBed~~ [WIP] feat(ivy): implement TestBed Aug 8, 2018

vicb added the state: WIP label Aug 8, 2018

vicb mentioned this pull request Aug 8, 2018

[IVY] TestBed missing features #25389

Closed

4 tasks

JoostK reviewed Aug 8, 2018

View reviewed changes

vicb force-pushed the 07-r3tb branch 2 times, most recently from 261b70d to ba51342 Compare August 8, 2018 23:03

mhevery previously requested changes Aug 9, 2018

View reviewed changes

vicb force-pushed the 07-r3tb branch 7 times, most recently from 5713bb5 to 9677059 Compare August 9, 2018 23:33

vicb changed the title ~~[WIP] feat(ivy): implement TestBed~~ feat(ivy): implement TestBed Aug 9, 2018

vicb added feature Issue that requests a new feature target: major This PR is targeted for the next major release and removed state: WIP labels Aug 9, 2018

vicb force-pushed the 07-r3tb branch 2 times, most recently from 86b0064 to 89aed19 Compare August 10, 2018 05:49

angular deleted a comment from mary-poppins Aug 10, 2018

vicb force-pushed the 07-r3tb branch from db536f8 to 89f7b91 Compare August 13, 2018 17:10

mhevery approved these changes Aug 13, 2018

View reviewed changes

vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 14, 2018

vicb added 7 commits August 14, 2018 07:48

refactor(ivy): misc cleanup

96abb35

feat(ivy): implement TestBed

a9faa3e

fixup! feat(ivy): implement TestBed

95af433

fixup! feat(ivy): implement TestBed

633ffa9

fixup! feat(ivy): implement TestBed

ffb1217

fixup! feat(ivy): implement TestBed

5a5ba80

fixup! feat(ivy): implement TestBed

460d984

vicb force-pushed the 07-r3tb branch from d084e80 to 460d984 Compare August 14, 2018 14:48

benlesh closed this in 8510637 Aug 14, 2018

benlesh pushed a commit that referenced this pull request Aug 14, 2018

feat(ivy): implement TestBed (#25369)

14ac7ad

PR Close #25369

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

refactor(ivy): misc cleanup (angular#25369)

26d2488

PR Close angular#25369

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

feat(ivy): implement TestBed (angular#25369)

2a846d0

PR Close angular#25369

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ivy): implement TestBed #25369

feat(ivy): implement TestBed #25369

vicb commented Aug 7, 2018 •

edited

JoostK Aug 8, 2018

mhevery Aug 8, 2018

mhevery Aug 8, 2018

mhevery Aug 8, 2018

mhevery Aug 8, 2018

mhevery Aug 8, 2018

mhevery Aug 9, 2018

mhevery Aug 9, 2018

vicb commented Aug 9, 2018

gregmagolan commented Aug 10, 2018 •

edited

gregmagolan commented Aug 10, 2018 •

edited

gregmagolan commented Aug 10, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

vicb commented Aug 14, 2018

vicb commented Aug 14, 2018

mary-poppins commented Aug 14, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

feat(ivy): implement TestBed #25369

feat(ivy): implement TestBed #25369

Conversation

vicb commented Aug 7, 2018 • edited

Notes

Todo

Recommended usage

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vicb commented Aug 9, 2018

gregmagolan commented Aug 10, 2018 • edited

gregmagolan commented Aug 10, 2018 • edited

gregmagolan commented Aug 10, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 13, 2018

vicb commented Aug 14, 2018

vicb commented Aug 14, 2018

mary-poppins commented Aug 14, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

vicb commented Aug 7, 2018 •

edited

gregmagolan commented Aug 10, 2018 •

edited

gregmagolan commented Aug 10, 2018 •

edited