docs(ivy): add better documentation around debugging ivy tests #25432

benlesh · 2018-08-10T19:50:59Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Updating docs.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Just adding more information about build flags and the like.

JoostK · 2018-08-10T19:56:54Z

docs/BAZEL.md

+See also: [`./src/ivy_switch.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch.ts) for more details.
+
+- `--config=debug`: build and launch in debug mode (see [debugging](#debugging) instructions below)
+- `--define=compile=<option>` Controls if ivy or legacy mode is enabled. This is down by generating the [`src/ivy_switch.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch.ts) file from [`ivy_switch_legacy.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_legacy.ts) (default), [`ivy_switch_jit.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_jit.ts), or [`ivy_switch_local.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_local.ts).


This is down -> This is done

vicb · 2018-08-10T21:29:20Z

docs/BAZEL.md

+
+- `--config=debug`: build and launch in debug mode (see [debugging](#debugging) instructions below)
+- `--define=compile=<option>` Controls if ivy or legacy mode is enabled. This is down by generating the [`src/ivy_switch.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch.ts) file from [`ivy_switch_legacy.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_legacy.ts) (default), [`ivy_switch_jit.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_jit.ts), or [`ivy_switch_local.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch_local.ts).
+    - `legacy`: (default behavior) compile against legacy renderer, e.g. `--define=compile=legacy`


"legacy renderer` -> "View Engine" ?

vicb · 2018-08-10T21:30:54Z

docs/BAZEL.md

+    - `local`: Compile in ivy AOT move, e.g. `--define=compile=local`
+- `--test_tag_filters=<tag>`: filter tests down to tags defined in the `tag` config
+of your rules in any given `BUILD.bazel`.
+    - `ivy-jit`: Only run tests that have to do with ivy JIT, e.g. `--test_tag_filters=ivy-jit`, e.g. `--test_tag_filters=ivy-local`. For this,


Change "Only run tests that have to do with ivy JIT" to "This flag should be set for tests that should be excuted with ivy JIT" ?

Yup. There were other issues there too.

vicb · 2018-08-10T21:32:36Z

docs/BAZEL.md

@@ -107,6 +129,7 @@ First time setup:
        },
 ```

+** Setting breakpoints directly in your code files may not work in VSCode**.


why ? / what should I do then ?
(Do you refer to the fact that bkpoints should be added to built file in /private/... ?)

Yeah... I'm not sure what to put there... people should add debugger statements to get it to stop at the right spot.

Okay, updated.

vicb · 2018-08-10T21:33:56Z

docs/BAZEL.md

+
+See also: [`//tools/bazel.rc`](https://github.com/angular/angular/blob/master/tools/bazel.rc) where `--define=ivy=false` is defined as default.
+
+See also: [`./src/ivy_switch.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch.ts) for more details.


Aren't comments in ./src/ivy_switch.ts outdated ? Shouldn't that file refer to here ? (and the same for the bazel files)

Yup... updating that.

mary-poppins · 2018-08-13T23:53:11Z

You can preview 6f51918 at https://pr25432-6f51918.ngbuilds.io/.

mary-poppins · 2018-08-14T00:01:06Z

You can preview 26adfd2 at https://pr25432-26adfd2.ngbuilds.io/.

ngbot · 2018-08-14T00:24:09Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "continuous-integration/travis-ci/pr" is failing
     missing required status "code-review/pullapprove"
     status "google3" is pending
     status "ci/circleci: test" is pending
     status "ci/circleci: integration_test" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

…ar#25432) PR Close angular#25432

angular-automatic-lock-bot · 2019-09-13T23:21:06Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 10, 2018

benlesh added area: bazel Issues related to the published `@angular/bazel` build rules target: major This PR is targeted for the next major release labels Aug 10, 2018

docs(ivy): add better documentation around debugging ivy tests

34323c5

benlesh force-pushed the ivy-debug-docs branch from 14595bb to 34323c5 Compare August 10, 2018 19:52

JoostK reviewed Aug 10, 2018

View reviewed changes

vicb reviewed Aug 10, 2018

View reviewed changes

benlesh added 2 commits August 13, 2018 16:45

fixup! docs(ivy): add better documentation around debugging ivy tests

6f51918

fixup! docs(ivy): add better documentation around debugging ivy tests

26adfd2

vicb approved these changes Aug 13, 2018

View reviewed changes

benlesh added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2018

benlesh closed this in bbb3f8f Aug 14, 2018

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

docs(ivy): add better documentation around debugging ivy tests (angul…

41cc808

…ar#25432) PR Close angular#25432

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(ivy): add better documentation around debugging ivy tests #25432

docs(ivy): add better documentation around debugging ivy tests #25432

benlesh commented Aug 10, 2018

JoostK Aug 10, 2018

benlesh Aug 13, 2018

vicb Aug 10, 2018

benlesh Aug 13, 2018

vicb Aug 10, 2018

benlesh Aug 13, 2018

vicb Aug 10, 2018

benlesh Aug 13, 2018

benlesh Aug 13, 2018

vicb Aug 10, 2018

benlesh Aug 13, 2018

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 14, 2018

ngbot bot commented Aug 14, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019


		See also: [`//tools/bazel.rc`](https://github.com/angular/angular/blob/master/tools/bazel.rc) where `--define=ivy=false` is defined as default.

		See also: [`./src/ivy_switch.ts`](https://github.com/angular/angular/blob/master/packages/core/src/ivy_switch.ts) for more details.

docs(ivy): add better documentation around debugging ivy tests #25432

docs(ivy): add better documentation around debugging ivy tests #25432

Conversation

benlesh commented Aug 10, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mary-poppins commented Aug 13, 2018

mary-poppins commented Aug 14, 2018

ngbot bot commented Aug 14, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019