test(ivy): compiler compliance tests should support ? #25435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
type: bug/fix
action: review
mhevery
approved these changes
Aug 10, 2018
kara
removed
the
action: review
|
You can preview 90ddd42 at https://pr25435-90ddd42.ngbuilds.io/. |
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way that the compiler compliance test matches compilation output to expected output. We were missing the
?operator from our regexp list, which was causing the tests to completely ignore any expected output after?in a test.This was causing the pure functions test to pass when it actually should have failed. While the compiler still generates the correct code for pure functions, the expected output string was incorrect in the test (switched the pipe index and slot offset args, for example). The test has been fixed.