feat(ivy): add query inheritance #25556
Conversation
benlesh
force-pushed
the
ivy-query-inheritance
branch
from
7b099ed
to
a746c0e
Compare
| const superViewQuery = superDef.viewQuery; | ||
| if (superViewQuery) { | ||
| if (prevViewQuery) { | ||
| // tslint:disable-next-line:no-any viewQuery is readonly, but we need to set it |
There was a problem hiding this comment.
I don't see why you need this tslint disable. There must be something weird about your setup. We should investigate.
Preferred way is (definition as {viewQuery: ViewQuery}).viewQuery = ...
Also we could just take the readonly away?
There was a problem hiding this comment.
Also we could just take the readonly away?
We can, I just didn't want to do that if it was supposed to be readonly as a public API.
| prevViewQuery(rf, ctx); | ||
| }; | ||
| } else { | ||
| // tslint:disable-next-line:no-any viewQuery is readonly, but we need to set it |
| it('should compose viewQuery', () => { | ||
| const log: Array<[string, RenderFlags, any]> = []; | ||
|
|
||
| // tslint:disable-next-line:class-as-namespace |
There was a problem hiding this comment.
done... removed from entire file
| }); | ||
| } | ||
|
|
||
| // tslint:disable-next-line:class-as-namespace |
There was a problem hiding this comment.
done... removed from entire file
| it('should compose contentQueries', () => { | ||
| const log: string[] = []; | ||
|
|
||
| // tslint:disable-next-line:class-as-namespace |
| }); | ||
| } | ||
|
|
||
| // tslint:disable-next-line:class-as-namespace |
Adds inheritance handling for the following: - viewQuery - contentQueries - contentQueriesRefresh
benlesh
force-pushed
the
ivy-query-inheritance
branch
from
0ecae68
to
bbf955a
Compare
|
You can preview bbf955a at https://pr25556-bbf955a.ngbuilds.io/. |
benlesh
added
action: merge
|
There's one Travis job that seems to be flaky. |
Adds inheritance handling for the following: - viewQuery - contentQueries - contentQueriesRefresh PR Close angular#25556
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds inheritance handling for the following: