Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform-server): update domino to v2.1.0 #25564

Closed
wants to merge 5 commits into from
Closed

feat(platform-server): update domino to v2.1.0 #25564

wants to merge 5 commits into from

Conversation

CaerusKaru
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

IgorMinar
IgorMinar reviewed Aug 22, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the class="" this looks good to me.

packages/core/test/render3/compiler_canonical/elements_spec.ts

// This is a fix for a change in how Domino renders this on the server in v2.1.0
const source = toHtml(comp);
const matches = source === '<div></div>' || source === '<div class=""></div>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird. why would it serialize an empty string attribute? are we doing something that triggers this behavior?

my concern is that we'll be bloating the html size if we happen to do this on every element.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about domino, but some attributes affect the element behavior even if empty.

The || is weird though. Are the tests run against multiple versions of Domino?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are run against Domino and against the browser. The browser does not exhibit this behavior, but Domino does, so the test needs to accept both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should understand why domino does this. Emitting these extra classes will cause HTML bloat which is undesirable.

Does this happen only on some elements or all elements? is this a bug in domino that we should report and fix?

I don't feel comfortable forcing people to update to domino 2.1 if it causes these kinds of issues, so before we do so, we need to understand the severity of this issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class issue is only on this test because it does the following: create a div, attach a conditional class based on a boolean for the component (initialized to false), then set the boolean to true. In every other test, there is no bloat, but the act of initializing an empty class in Domino results in an empty string on the div.

@IgorMinar IgorMinar added area: server Issues related to server-side rendering target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 22, 2018
skreborn
skreborn reviewed Aug 22, 2018
View reviewed changes
packages/platform-server/test/integration_spec.ts
@@ -588,7 +588,7 @@ class HiddenModule {
expect(output).toContain('Works!');
expect(output).toContain('ng-trigger-myAnimation');
expect(output).toContain('opacity:1;');
expect(output).toContain('transform:translate3d(0, 0, 0);');
expect(output).toContain('transform:translate3d(0 , 0 , 0);');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add extra spaces here? This seems like an accident.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not an accident, Domino changed how it serializes that particular form of CSS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's an awfully strange change to make, but who am I to question their decision? All good then, thanks for the clarification!

IgorMinar
IgorMinar approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed this with Vikram and the change looks good to me. The empty attribute issue doesn't seem to be widespread enough to warrant blocking this.

IgorMinar
IgorMinar approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed this with Vikram and the change looks good to me. The empty attribute issue doesn't seem to be widespread enough to warrant blocking this.

This PR however needs to be rebased before we can merge it.

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 19, 2018
@vikerman vikerman added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 19, 2018
@kara kara closed this in 3fb0da2 Sep 19, 2018
@CaerusKaru CaerusKaru deleted the domino21 branch September 20, 2018 00:13
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@CaerusKaru @FrederikSchlemmer
feat(platform-server): update domino to v2.1.0 (angular#25564)
039d9f8 
PR Close angular#25564
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skreborn skreborn skreborn left review comments

@gkalpak gkalpak gkalpak left review comments

@vikerman vikerman vikerman approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees

@vikerman vikerman

Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CaerusKaru @vikerman @IgorMinar @skreborn @gkalpak @googlebot