fix(ivy): <ng-container> fixes #25617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
|
You can preview 70866ec at https://pr25617-70866ec.ngbuilds.io/. |
alfaproject
reviewed
Aug 22, 2018
| } | ||
|
|
||
| function typeName(type: TNodeType): string { | ||
| if (type == TNodeType.Projection) return 'Projection'; | ||
| if (type == TNodeType.Container) return 'Container'; | ||
| if (type == TNodeType.View) return 'View'; | ||
| if (type == TNodeType.Element) return 'Element'; | ||
| if (type == TNodeType.ElementContainer) return 'ElementContainer'; | ||
| return '<unknown>'; |
There was a problem hiding this comment.
Would this be more performant? j/w
// Move this object outside so it only gets created once
const nodeTypeName = {
TNodeType.Projection: 'Projection',
TNodeType.Container: 'Container',
TNodeType.View: 'View',
TNodeType.Element: 'Element',
TNodeType.ElementContainer: 'ElementContainer',
};
return nodeTypeName[type] || '<unknown>';There was a problem hiding this comment.
I don't think that performance is consideration here since this is just assert code not present in production bundles.
kara
reviewed
Aug 22, 2018
| elementContainerEnd(); | ||
| } | ||
| if (rf & RenderFlags.Update) { | ||
| const tplRef = load(1); |
There was a problem hiding this comment.
Right, good catch, thnx!
pkozlowski-opensource
force-pushed
the
ivy_vcref_ng_container
branch
from
70866ec
to
277a8ba
Compare
|
You can preview 277a8ba at https://pr25617-277a8ba.ngbuilds.io/. |
kara
added
type: bug/fix
and removed
action: review
pkozlowski-opensource
added
the
action: merge
matsko
pushed a commit
that referenced
this pull request
Aug 24, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for 2 issues discovered when running TestBed spec on the existing tests from the
commonpackage.In both cases the issue boiled down to taking new node type into account when doing checks.