test(common): fix double instantiation in NgSwitch test #25632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the tests was creating TestComponent instance _and_ using global state making this test not predictable. Fixing the test by making sure that TestComponent is instantiated only once.
pkozlowski-opensource
added
action: review
|
You can preview ab71817 at https://pr25632-ab71817.ngbuilds.io/. |
mhevery
approved these changes
Aug 27, 2018
mhevery
added
action: merge
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
One of the tests was creating TestComponent instance _and_ using global state making this test not predictable. Fixing the test by making sure that TestComponent is instantiated only once. PR Close angular#25632
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tests was creating TestComponent instance and using
global state making this test not predictable. Fixing the test
by making sure that TestComponent is instantiated only once.
This PR is needed to unblock
TestBedtests for ivy.