New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove tsickle from compiler-cli deps #25649
Conversation
You can preview 93085dd at https://pr25649-93085dd.ngbuilds.io/. |
You can preview e36d92f at https://pr25649-e36d92f.ngbuilds.io/. |
e36d92f
to
0fbe9dd
Compare
You can preview 0fbe9dd at https://pr25649-0fbe9dd.ngbuilds.io/. |
0fbe9dd
to
d6dfdc9
Compare
You can preview d6dfdc9 at https://pr25649-d6dfdc9.ngbuilds.io/. |
Alex R. says that we no longer care about the behavior this is testing.
Users can still install tsickle if they want closure-compatible output.
d6dfdc9
to
363339b
Compare
You can preview 363339b at https://pr25649-363339b.ngbuilds.io/. |
Code-wise, this LGTM. I'm pondering the larger implications, though. Historically the interaction between tsickle and compiler-cli has caused issues in a few places, and this tends to be much worse in Ivy where the AST we feed tsickle can be noticeably changed from the original source code. Tsickle does much of its work using the original source text. I'm wary that removing Thoughts? |
We have the |
Users can still install tsickle if they want closure-compatible output. PR Close #25649
…ngular#25649) Alex R. says that we no longer care about the behavior this is testing. PR Close angular#25649
Users can still install tsickle if they want closure-compatible output. PR Close angular#25649
…ngular#25649) Alex R. says that we no longer care about the behavior this is testing. PR Close angular#25649
Users can still install tsickle if they want closure-compatible output. PR Close angular#25649
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information