Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove tsickle from compiler-cli deps #25649

Closed
wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@mary-poppins
Copy link

You can preview 93085dd at https://pr25649-93085dd.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e36d92f at https://pr25649-e36d92f.ngbuilds.io/.

@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Aug 27, 2018
@mary-poppins
Copy link

You can preview 0fbe9dd at https://pr25649-0fbe9dd.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d6dfdc9 at https://pr25649-d6dfdc9.ngbuilds.io/.

Alex R. says that we no longer care about the behavior this is testing.
Users can still install tsickle if they want closure-compatible output.
@mary-poppins
Copy link

You can preview 363339b at https://pr25649-363339b.ngbuilds.io/.

@alexeagle alexeagle changed the title build: WIP remove tsickle from compiler-cli deps build: remove tsickle from compiler-cli deps Aug 27, 2018
@alxhub
Copy link
Member

alxhub commented Aug 28, 2018

Code-wise, this LGTM.

I'm pondering the larger implications, though. Historically the interaction between tsickle and compiler-cli has caused issues in a few places, and this tends to be much worse in Ivy where the AST we feed tsickle can be noticeably changed from the original source code. Tsickle does much of its work using the original source text.

I'm wary that removing tsickle as a step in our tests will introduce bugs which only show up at g3sync time. Then again, most of our tests run without annotateForClosureCompiler enabled anyway, so maybe this isn't a new concern.

Thoughts?

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2018
@alexeagle
Copy link
Contributor Author

We have the integration/hello-world-closure test which is the best place for us to locally catch gross regressions of using closure.

@matsko matsko closed this in a22fb91 Aug 28, 2018
matsko pushed a commit that referenced this pull request Aug 28, 2018
Users can still install tsickle if they want closure-compatible output.

PR Close #25649
petebacondarwin pushed a commit to petebacondarwin/angular that referenced this pull request Sep 3, 2018
…ngular#25649)

Alex R. says that we no longer care about the behavior this is testing.

PR Close angular#25649
petebacondarwin pushed a commit to petebacondarwin/angular that referenced this pull request Sep 3, 2018
Users can still install tsickle if they want closure-compatible output.

PR Close angular#25649
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
…ngular#25649)

Alex R. says that we no longer care about the behavior this is testing.

PR Close angular#25649
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
Users can still install tsickle if they want closure-compatible output.

PR Close angular#25649
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants