New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): register to directive outputs on ng-template / ng-container #25698
Closed
pkozlowski-opensource
wants to merge
1
commit into
angular:master
from
pkozlowski-opensource:listener_ng_template_ng_container
Closed
fix(ivy): register to directive outputs on ng-template / ng-container #25698
pkozlowski-opensource
wants to merge
1
commit into
angular:master
from
pkozlowski-opensource:listener_ng_template_ng_container
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
target: major
This PR is targeted for the next major release
comp: ivy
labels
Aug 28, 2018
2 tasks
You can preview 726dcbf at https://pr25698-726dcbf.ngbuilds.io/. |
pkozlowski-opensource
force-pushed
the
listener_ng_template_ng_container
branch
from
August 28, 2018 15:42
726dcbf
to
5b6b30e
Compare
You can preview 5b6b30e at https://pr25698-5b6b30e.ngbuilds.io/. |
mhevery
approved these changes
Aug 28, 2018
mhevery
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Aug 28, 2018
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 29, 2018
Compiler part of angular#25698 Fixes angular#25697
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 29, 2018
Compiler part of angular#25698 Fixes angular#25697
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 31, 2018
Compiler part of angular#25698 Fixes angular#25697
mhevery
pushed a commit
that referenced
this pull request
Aug 31, 2018
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this pull request
Sep 3, 2018
…angular#25698) Runtime part of angular#25697 PR Close angular#25698
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this pull request
Sep 3, 2018
Compiler part of angular#25698 Fixes angular#25697 PR Close angular#25717
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…angular#25698) Runtime part of angular#25697 PR Close angular#25698
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
Compiler part of angular#25698 Fixes angular#25697 PR Close angular#25717
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime part of #25697
Compiler part will be done as soon as we are fine with the generated code.