Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs-infra): ensure root node_modules exists #25811

Closed
wants to merge 1 commit into from
Closed

build(docs-infra): ensure root node_modules exists #25811

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Now that the doc-gen parses the imports of TS source
files we need to ensure that the root node_modules
exists. Otherwise running yarn docs produces an
obscure error:

Error: No SourceFile found with path node_modules/@types/jasmine/index.d.ts

Closes #25759

@petebacondarwin
build(docs-infra): ensure root node_modules exists
963226e 
Now that the doc-gen parses the imports of TS source
files we need to ensure that the root node_modules
exists. Otherwise running `yarn docs` produces an
obscure error:

```
Error: No SourceFile found with path node_modules/@types/jasmine/index.d.ts
```

Closes angular#25759
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours severity2: inconvenient target: patch This PR is targeted for the next patch release risk: low labels Sep 5, 2018
@mary-poppins
Copy link

You can preview 963226e at https://pr25811-963226e.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 5, 2018
@petebacondarwin petebacondarwin added this to MERGE in docs-infra Sep 5, 2018
mhevery pushed a commit that referenced this pull request Sep 5, 2018
@petebacondarwin @mhevery
build(docs-infra): ensure root node_modules exists (#25811)
d752a89 
Now that the doc-gen parses the imports of TS source
files we need to ensure that the root node_modules
exists. Otherwise running `yarn docs` produces an
obscure error:

```
Error: No SourceFile found with path node_modules/@types/jasmine/index.d.ts
```

Closes #25759

PR Close #25811
@mhevery mhevery closed this in c1ae3c1 Sep 5, 2018
@petebacondarwin petebacondarwin deleted the aio-root-yarn branch September 6, 2018 07:37
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@petebacondarwin @FrederikSchlemmer
build(docs-infra): ensure root node_modules exists (angular#25811)
9b3ff32 
Now that the doc-gen parses the imports of TS source
files we need to ensure that the root node_modules
exists. Otherwise running `yarn docs` produces an
obscure error:

```
Error: No SourceFile found with path node_modules/@types/jasmine/index.d.ts
```

Closes angular#25759

PR Close angular#25811
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release
Projects
docs-infra
MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular AIO General Setup - Missing instructions needed in the root
4 participants
@petebacondarwin @mary-poppins @gkalpak @googlebot