Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-infra): re-enable SW offline mode #25826

Closed
wants to merge 1 commit into from
Closed

fix(docs-infra): re-enable SW offline mode #25826

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 5, 2018

This basically reverts #25692, since Firebase has fixed the issue with /index.html redirection on their side.

@gkalpak
fix(docs-infra): re-enable SW offline mode
fcc78d6 
This basically reverts angular#25692, since Firebase has fixed the issue with
`/index.html` redirection on their side.
@gkalpak gkalpak added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra target: major This PR is targeted for the next major release labels Sep 5, 2018
@gkalpak gkalpak added this to WIP in docs-infra Sep 5, 2018
@gkalpak gkalpak moved this from WIP to REVIEW in docs-infra Sep 5, 2018
@mary-poppins
Copy link

You can preview fcc78d6 at https://pr25826-fcc78d6.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 6, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Sep 6, 2018 •
edited

Note to caretaker: @petebacondarwin approved it (and he's in the all group); not sure why PullApprove is still not happy 😕

@gkalpak gkalpak moved this from REVIEW to MERGE in docs-infra Sep 6, 2018
@gkalpak gkalpak added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 6, 2018
@IgorMinar IgorMinar closed this in 152de20 Sep 6, 2018
@gkalpak gkalpak deleted the fix-aio-enable-offline-sw branch September 7, 2018 08:20
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@gkalpak @FrederikSchlemmer
fix(docs-infra): re-enable SW offline mode (angular#25826)
3c42b5a 
This basically reverts angular#25692, since Firebase has fixed the issue with
`/index.html` redirection on their side.

PR Close angular#25826
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

@ocombe ocombe ocombe approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
docs-infra
MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gkalpak @mary-poppins @petebacondarwin @IgorMinar @ocombe @googlebot