feat(ivy): support animation @triggers in templates #25849
Conversation
|
You can preview 56f07e0 at https://pr25849-56f07e0.ngbuilds.io/. |
| if (rf & 2) { | ||
| $r3$.ɵelementAttribute(0, "@foo", $r3$.ɵbind(ctx.exp)); | ||
| $r3$.ɵelementAttribute(1, "@bar", undefined); | ||
| $r3$.ɵelementAttribute(2, "@baz", undefined); |
There was a problem hiding this comment.
I don't think this is desirable. If the value is constant (undefined) it shouldn't need to be reevaluated each update, should it? Also, because this doesn't use bind it will never be NO_CHANGE, in which case the attribute is thought to have changed during each change detection run.
There was a problem hiding this comment.
Yes, this test is not canonical, and will confuse people reading it. Can you make it canonical by binding to a value, which may be constant for the test.
There was a problem hiding this comment.
How's about just setting the undefined value to be NO_CHANGE?
There was a problem hiding this comment.
@matsko It won't do a thing, then ;) Basically, constant attributes are usually applied for RenderFlags.Create by passing the constant attributes as third argument to elementStart.
There was a problem hiding this comment.
OK the instructions are gone.
|
|
||
| const template = ` | ||
| MyComponent.ngComponentDef = $r3$.ɵdefineComponent({ | ||
| type: MyComponent, |
There was a problem hiding this comment.
you can use ... to elide irrelevant text and only keep animations.
MyComponent.ngComponentDef = $r3$.ɵdefineComponent({
...
animations: [{name: "foo123"}, {name: "trigger123"}]
...
});
| features: [$r3$.ɵPublicFeature], | ||
| consts: 0, | ||
| vars: 0, | ||
| template: function MyComponent_Template(rf, $ctx$) { |
There was a problem hiding this comment.
same here, elide irrelevant text.
| if (rf & 2) { | ||
| $r3$.ɵelementAttribute(0, "@foo", $r3$.ɵbind(ctx.exp)); | ||
| $r3$.ɵelementAttribute(1, "@bar", undefined); | ||
| $r3$.ɵelementAttribute(2, "@baz", undefined); |
There was a problem hiding this comment.
Yes, this test is not canonical, and will confuse people reading it. Can you make it canonical by binding to a value, which may be constant for the test.
matsko
force-pushed
the
ivy_attr_triggers
branch
from
56f07e0
to
bce5721
Compare
|
You can preview bce5721 at https://pr25849-bce5721.ngbuilds.io/. |
matsko
force-pushed
the
ivy_attr_triggers
branch
from
bce5721
to
5d211ba
Compare
|
You can preview 5d211ba at https://pr25849-5d211ba.ngbuilds.io/. |
matsko
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.