docs: warn that directives don't support namespaces #25855

s-gbz · 2018-09-07T10:33:58Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
Augments current documentation.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The issue has not been documented.

Issue Number: #24971

What is the new behavior?

Explicitly states that namespace are not supported in directives
and gives an example of how it's not done.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Is this there anything to add @jenniferfell?

mary-poppins · 2018-09-12T13:11:08Z

You can preview c6c546b at https://pr25855-c6c546b.ngbuilds.io/.
You can preview df829da at https://pr25855-df829da.ngbuilds.io/.

brandonroberts

Update git commit message to docs: warn that directives don't support namespaces

brandonroberts · 2018-09-12T13:12:36Z

aio/content/examples/attribute-directives/src/app/app.component.1.html

-<!-- #enddocregion applied,  -->
+<!-- #enddocregion applied  -->
+
+<!-- #docregion unsupported -->


Is this needed even though you have this in a separate file?

Sorry, what do you mean? I just followed the given examples 😄

@s-gbz He means that you can remove lines 7-9 since you have this already in app.component.avoid.html. Does that help?

Yes, if im supposed to just delete lines 7-9 and push again 😀

Yes, I think that's it. 🙂

kapunahelewong

Thanks for this, @s-gbz! :) I have only one small comment.

aio/content/guide/attribute-directives.md

mary-poppins · 2018-09-20T06:48:29Z

You can preview f7eedb9 at https://pr25855-f7eedb9.ngbuilds.io/.

mary-poppins · 2018-09-20T09:53:41Z

You can preview 22182a0 at https://pr25855-22182a0.ngbuilds.io/.

kapunahelewong

Though we generally try to avoid don't-do-this examples, this one seems reasonable.

brandonroberts · 2019-01-29T15:38:28Z

@s-gbz will you remove the extra lines? Everything else LGTM.

aio/content/guide/attribute-directives.md

brandonroberts

title must be changed to header

googlebot · 2019-01-30T09:45:34Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2019-01-30T09:50:04Z

You can preview 1d053e0 at https://pr25855-1d053e0.ngbuilds.io/.

mary-poppins · 2019-01-30T09:55:50Z

You can preview 9dbce69 at https://pr25855-9dbce69.ngbuilds.io/.

s-gbz · 2019-02-05T13:52:10Z

Hello @brandonroberts, could we wrap this up real'quick? 😄

brandonroberts · 2019-02-05T19:28:46Z

@s-gbz sure. Something has changed with your CLA status. Will you rebase on master and squash down to a single commit?

googlebot · 2019-02-06T08:20:58Z

CLAs look good, thanks!

mary-poppins · 2019-02-06T08:24:44Z

You can preview 426f147 at https://pr25855-426f147.ngbuilds.io/.

s-gbz · 2019-02-06T08:48:51Z

@brandonroberts guess we did it then 🎉

s-gbz · 2019-02-19T12:49:08Z

@brandonroberts I just rebased the PR on current master *again. LGTM?

mary-poppins · 2019-02-19T12:52:04Z

You can preview 2c0e5cc at https://pr25855-2c0e5cc.ngbuilds.io/.

brandonroberts · 2019-02-19T13:16:42Z

Thanks for your work on this @s-gbz! Hopefully next time it won't take as long.

PR Close #25855

angular-automatic-lock-bot · 2019-09-14T18:23:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Sep 7, 2018

s-gbz changed the title ~~docs: Warn that directives don't support namespaces~~ [WIP] docs: Warn that directives don't support namespaces Sep 7, 2018

s-gbz changed the title ~~[WIP] docs: Warn that directives don't support namespaces~~ docs: Warn that directives don't support namespaces Sep 7, 2018

brandonroberts self-assigned this Sep 12, 2018

brandonroberts suggested changes Sep 12, 2018

View reviewed changes

brandonroberts requested a review from kapunahelewong September 12, 2018 13:13

kapunahelewong suggested changes Sep 12, 2018

View reviewed changes

aio/content/guide/attribute-directives.md Outdated Show resolved Hide resolved

s-gbz force-pushed the doc-selector-no-namespace branch from df829da to f7eedb9 Compare September 20, 2018 06:35

s-gbz force-pushed the doc-selector-no-namespace branch from f7eedb9 to 22182a0 Compare September 20, 2018 09:46

kapunahelewong approved these changes Jan 14, 2019

View reviewed changes

brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 14, 2019

ngbot bot added this to the needsTriage milestone Jan 14, 2019

brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 14, 2019

brandonroberts added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Jan 22, 2019

brandonroberts added the feature Issue that requests a new feature label Jan 29, 2019

brandonroberts reviewed Jan 29, 2019

View reviewed changes

aio/content/guide/attribute-directives.md Outdated Show resolved Hide resolved

brandonroberts suggested changes Jan 29, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels Jan 30, 2019

s-gbz force-pushed the doc-selector-no-namespace branch from 1d053e0 to 9dbce69 Compare January 30, 2019 09:51

s-gbz force-pushed the doc-selector-no-namespace branch from 9dbce69 to 426f147 Compare February 6, 2019 08:20

googlebot added cla: yes and removed cla: no labels Feb 6, 2019

docs: warn that directives don't support namespaces

2c0e5cc

s-gbz force-pushed the doc-selector-no-namespace branch from 426f147 to 2c0e5cc Compare February 19, 2019 12:48

brandonroberts approved these changes Feb 19, 2019

View reviewed changes

brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 19, 2019

IgorMinar approved these changes Feb 19, 2019

View reviewed changes

IgorMinar pushed a commit that referenced this pull request Feb 19, 2019

docs: warn that directives don't support namespaces (#25855)

b8c2f3b

PR Close #25855

IgorMinar closed this in 980bb52 Feb 19, 2019

s-gbz deleted the doc-selector-no-namespace branch February 27, 2019 12:52

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: warn that directives don't support namespaces #25855

docs: warn that directives don't support namespaces #25855

s-gbz commented Sep 7, 2018 •

edited

mary-poppins commented Sep 12, 2018

brandonroberts left a comment

brandonroberts Sep 12, 2018

s-gbz Sep 20, 2018

kapunahelewong Jan 14, 2019

s-gbz Jan 15, 2019

kapunahelewong Jan 15, 2019

kapunahelewong left a comment

mary-poppins commented Sep 20, 2018

mary-poppins commented Sep 20, 2018

kapunahelewong left a comment

brandonroberts commented Jan 29, 2019

brandonroberts left a comment

googlebot commented Jan 30, 2019

mary-poppins commented Jan 30, 2019

mary-poppins commented Jan 30, 2019

s-gbz commented Feb 5, 2019

brandonroberts commented Feb 5, 2019

googlebot commented Feb 6, 2019

mary-poppins commented Feb 6, 2019

s-gbz commented Feb 6, 2019

s-gbz commented Feb 19, 2019 •

edited

mary-poppins commented Feb 19, 2019

brandonroberts commented Feb 19, 2019

angular-automatic-lock-bot bot commented Sep 14, 2019

docs: warn that directives don't support namespaces #25855

docs: warn that directives don't support namespaces #25855

Conversation

s-gbz commented Sep 7, 2018 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

mary-poppins commented Sep 12, 2018

brandonroberts left a comment

Choose a reason for hiding this comment

brandonroberts Sep 12, 2018

Choose a reason for hiding this comment

s-gbz Sep 20, 2018

Choose a reason for hiding this comment

kapunahelewong Jan 14, 2019

Choose a reason for hiding this comment

s-gbz Jan 15, 2019

Choose a reason for hiding this comment

kapunahelewong Jan 15, 2019

Choose a reason for hiding this comment

kapunahelewong left a comment

Choose a reason for hiding this comment

mary-poppins commented Sep 20, 2018

mary-poppins commented Sep 20, 2018

kapunahelewong left a comment

Choose a reason for hiding this comment

brandonroberts commented Jan 29, 2019

brandonroberts left a comment

Choose a reason for hiding this comment

googlebot commented Jan 30, 2019

mary-poppins commented Jan 30, 2019

mary-poppins commented Jan 30, 2019

s-gbz commented Feb 5, 2019

brandonroberts commented Feb 5, 2019

googlebot commented Feb 6, 2019

mary-poppins commented Feb 6, 2019

s-gbz commented Feb 6, 2019

s-gbz commented Feb 19, 2019 • edited

mary-poppins commented Feb 19, 2019

brandonroberts commented Feb 19, 2019

angular-automatic-lock-bot bot commented Sep 14, 2019

s-gbz commented Sep 7, 2018 •

edited

s-gbz commented Feb 19, 2019 •

edited