Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): traverse tNode tree directly #25872

Closed
wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Sep 8, 2018

This PR moves us off of traversing the node tree through LNodes, since LNodes are not going to be around much longer. Now the traversal occurs through TNodes. This change will help prepare us for removing node.tNode.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy labels Sep 8, 2018
@kara kara requested a review from mhevery September 8, 2018 18:00
@mary-poppins
Copy link

You can preview a61ea75 at https://pr25872-a61ea75.ngbuilds.io/.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 8, 2018
@mary-poppins
Copy link

You can preview 58d5a04 at https://pr25872-58d5a04.ngbuilds.io/.

@kara
Copy link
Contributor Author

kara commented Sep 8, 2018

presubmit

@kara kara added the action: merge The PR is ready for merge by the caretaker label Sep 8, 2018
@IgorMinar IgorMinar closed this in 91d7993 Sep 10, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants