Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): remove superfluous Array check #25894

Closed

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Sep 10, 2018

related #25755

Simply removes an unnecessary Array.isArray check that was left in from a previous change.

@benlesh benlesh added target: major This PR is targeted for the next major release and removed cla: yes labels Sep 10, 2018
@benlesh benlesh requested a review from alxhub September 10, 2018 17:44
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2018
@ngbot
Copy link

ngbot bot commented Sep 10, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "code-review/pullapprove"
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "ci/circleci: aio_preview" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test_ivy_jit" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@benlesh
Copy link
Contributor Author

benlesh commented Sep 10, 2018

@mary-poppins
Copy link

You can preview a6c3a92 at https://pr25894-a6c3a92.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 7ba0cb7 Sep 10, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants