Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ngcontainer): update BAZEL_VERSION to 0.17.1 #25967

Closed
wants to merge 2 commits into from
Closed

build(ngcontainer): update BAZEL_VERSION to 0.17.1 #25967

wants to merge 2 commits into from

Conversation

manekinekko
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Bazel version '0.16.1' doesn't seem to be available anymore! Updating to 0.17.1 to fix the issue.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Building the angular/ngcontainer fails with the following error:

E: Version '0.16.1' for 'bazel' was not found
The command '/bin/sh -c BAZEL_VERSION="0.16.1"  && wget -q -O - https://bazel.build/bazel-release.pub.gpg | apt-key add -  && echo "deb [arch=amd64] http://storage.googleapis.com/bazel-apt stable jdk1.8" > /etc/apt/sources.list.d/bazel.list  && apt-get update  && apt-get install -y bazel=$BAZEL_VERSION  && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
ERROR
ERROR: build step 0 "gcr.io/cloud-builders/docker" failed: exit status 100

Issue Number: N/A

What is the new behavior?

The build pass and a docker image is created.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Bazel version '0.16.1' doesn't seem to be available anymore! Upgrade to 0.17.1 instead.
@alexeagle
Copy link
Contributor

I'll take over the PR - there are more places to update (see previous updates)

@alexeagle alexeagle self-requested a review September 14, 2018 16:49
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Sep 14, 2018
this includes support for @ character in labels, which we need for fine-grained deps
@alexeagle alexeagle added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 17, 2018
@benlesh benlesh closed this in 2e32d4e Sep 17, 2018
benlesh pushed a commit that referenced this pull request Sep 17, 2018
this includes support for @ character in labels, which we need for fine-grained deps

PR Close #25967
alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
this includes support for @ character in labels, which we need for fine-grained deps

PR Close angular#25967
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
Bazel version '0.16.1' doesn't seem to be available anymore! Upgrade to 0.17.1 instead.

PR Close angular#25967
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
this includes support for @ character in labels, which we need for fine-grained deps

PR Close angular#25967
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants