New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ngcontainer): update BAZEL_VERSION to 0.17.1 #25967
Closed
manekinekko
wants to merge
2
commits into
angular:master
from
sfeir-open-source:manekinekko-ngcontainer-bazel-0.17.1
Closed
build(ngcontainer): update BAZEL_VERSION to 0.17.1 #25967
manekinekko
wants to merge
2
commits into
angular:master
from
sfeir-open-source:manekinekko-ngcontainer-bazel-0.17.1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel version '0.16.1' doesn't seem to be available anymore! Upgrade to 0.17.1 instead.
I'll take over the PR - there are more places to update (see previous updates) |
alexeagle
approved these changes
Sep 14, 2018
alexeagle
added
target: patch
This PR is targeted for the next patch release
action: merge
The PR is ready for merge by the caretaker
labels
Sep 14, 2018
alxhub
approved these changes
Sep 14, 2018
this includes support for @ character in labels, which we need for fine-grained deps
alexeagle
added
target: major
This PR is targeted for the next major release
and removed
target: patch
This PR is targeted for the next patch release
labels
Sep 17, 2018
benlesh
pushed a commit
that referenced
this pull request
Sep 17, 2018
this includes support for @ character in labels, which we need for fine-grained deps PR Close #25967
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Sep 18, 2018
this includes support for @ character in labels, which we need for fine-grained deps PR Close angular#25967
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
Bazel version '0.16.1' doesn't seem to be available anymore! Upgrade to 0.17.1 instead. PR Close angular#25967
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
this includes support for @ character in labels, which we need for fine-grained deps PR Close angular#25967
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Bazel version '0.16.1' doesn't seem to be available anymore! Updating to 0.17.1 to fix the issue.
What is the current behavior?
Building the
angular/ngcontainer
fails with the following error:Issue Number: N/A
What is the new behavior?
The build pass and a docker image is created.
Does this PR introduce a breaking change?
Other information