Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo fix #26386

Closed
wants to merge 1 commit into from
Closed

docs: typo fix #26386

wants to merge 1 commit into from

Conversation

lovelangy
Copy link
Contributor

according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@lovelangy
Copy link
Contributor Author

I signed it!

@ashishpatelcs
Copy link
Contributor

I signed it!

Make sure you have signed the CLA.

@lovelangy
Copy link
Contributor Author

I signed it!

Make sure you have signed the CLA.

thanks,I already signed it.

@googlebot
Copy link

CLAs look good, thanks!

@lovelangy lovelangy changed the title docs: type fix docs: typo fix Oct 12, 2018
@brandonroberts brandonroberts self-assigned this Oct 18, 2018
@brandonroberts brandonroberts added type: bug/fix comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours freq1: low area: forms target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Oct 18, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 18, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 18, 2018
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 18, 2018
@kara
Copy link
Contributor

kara commented Oct 18, 2018

@brandonroberts We haven't added forms-overview to pullapprove, so you'll need to approve this from docs team end

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 18, 2018
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 18, 2018
alxhub pushed a commit that referenced this pull request Oct 18, 2018
according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"
PR Close #26386
@alxhub alxhub closed this in 09cc458 Oct 18, 2018
@lovelangy lovelangy deleted the patch-1 branch October 23, 2018 09:51
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"
PR Close angular#26386
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"
PR Close angular#26386
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes effort1: hours freq1: low risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants