Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix tbd link and minor edits in deployment guide #26404

Closed
wants to merge 1 commit into from

Conversation

jenniferfell
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Deployment guide (https://next.angular.io/guide/deployment) ends with a TBD link for the CLI reference.

Issue Number: N/A

What is the new behavior?

Deployment guide links to CLI overview page https://next.angular.io/cli

Minor edits for consistency, mostly to refer to CLI commands as ng serve not just serve.

Does this PR introduce a breaking change?

[ ] Yes
[X ] No

Other information

@jenniferfell jenniferfell added comp: docs target: major This PR is targeted for the next major release labels Oct 11, 2018
@jenniferfell jenniferfell added this to the v7.0 milestone Oct 11, 2018
@mary-poppins
Copy link

You can preview ed08a41 at https://pr26404-ed08a41.ngbuilds.io/.

@jenniferfell jenniferfell added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 11, 2018
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 11, 2018
@ngbot
Copy link

ngbot bot commented Oct 11, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar
Copy link
Contributor

caretaker note: red ci is due to flakes.

@mhevery mhevery closed this in 1657c99 Oct 11, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants