Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): remove LNode #26426

Closed
wants to merge 1 commit into from
Closed

refactor(ivy): remove LNode #26426

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Oct 13, 2018

This PR removes the LNode object. We used to create an LNode object for every single DOM element.

So if you had an ngFor with 10,000 items like below, you'd get 10,000 LNode objects and 1 TNode

<div *ngFor="let row of rows"></div>

With this PR, the same template will only produce 1 TNode and 0 LNodes.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy and removed cla: yes labels Oct 13, 2018
@kara kara requested a review from mhevery October 13, 2018 01:53
@mary-poppins
Copy link

You can preview 1592ca4 at https://pr26426-1592ca4.ngbuilds.io/.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 14, 2018
@kara
Copy link
Contributor Author

kara commented Oct 14, 2018

presubmit

@kara kara added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2018
@mary-poppins
Copy link

You can preview 9784362 at https://pr26426-9784362.ngbuilds.io/.

@mhevery mhevery closed this in e76a570 Oct 15, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants