Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.1.x build upgrade jasminewd2 types #26432

Merged
merged 1 commit into from Oct 14, 2018
Merged

6.1.x build upgrade jasminewd2 types #26432

merged 1 commit into from Oct 14, 2018

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 13, 2018

Backports #26139 to 6.1.x.

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer PR target: patch-only labels Oct 13, 2018
@gkalpak gkalpak changed the base branch from master to 6.1.x October 13, 2018 08:51
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@gkalpak gkalpak mentioned this pull request Oct 13, 2018
Closed
@gkalpak
build: upgrade @types/jasminewd2 to 2.0.4
9aeb96a 
This commit also removes the extra jasminewd2 typings, since the
changes have been merged in the official typings with
DefinitelyTyped/DefinitelyTyped#28957.
@gkalpak gkalpak force-pushed the 6.1.x-build-upgrade-jasminewd2-types branch from 3e6b1f5 to 9aeb96a Compare October 13, 2018 09:18
@googlebot
Copy link

CLAs look good, thanks!

@mary-poppins
Copy link

You can preview 9aeb96a at https://pr26432-9aeb96a.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2018
@mhevery mhevery merged commit 1f06b6c into angular:6.1.x Oct 14, 2018
@gkalpak gkalpak deleted the 6.1.x-build-upgrade-jasminewd2-types branch October 14, 2018 10:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @googlebot @mary-poppins @mhevery