docs: forms intro copy edit #26450
Closed
docs: forms intro copy edit #26450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
added
comp: docs
action: review
brandonroberts
changed the title
|
You can preview a852d99 at https://pr26450-a852d99.ngbuilds.io/. |
kara
reviewed
Oct 16, 2018
aio/content/guide/forms-overview.md
Outdated
|
|
||
| - **Reactive forms** keep the data model pure by providing it as an immutable data structure. Each time a change is triggered on the data model, the `FormControl` instance returns a new data model rather than updating the data model directly. This gives you the ability track unique changes to the data model through the control's observable. This allows change detection to be more efficient because it only needs to update on unique changes. It also follows reactive patterns that integrate with observable operators to transform data. | ||
| - **Template-driven** forms rely on mutability with two-way data binding to update the data model in the component as changes are made in the template. Because there are no unique changes to track on the data model when using two-way data binding, change detection is less efficient at determining when updates are required. | ||
| * **Reactive forms** keep the data model pure by providing it as an immutable data structure. Each time a change is triggered on the data model, the `FormControl` instance returns a new data model rather than updating the existing data model. This gives you the ability track unique changes to the data model through the control's observable. As a result, change detection is more efficient because it only needs to update on unique changes. It also follows reactive patterns that integrate with observable operators to transform data. |
There was a problem hiding this comment.
Typo: ability track -> ability to track
I also think we should edit/remove the second-to-last sentence because it doesn't seem right. The phrasing here implies that change detection itself is gated on the observable.
There was a problem hiding this comment.
How about this?
This provides one way for change detection to be more efficient because it only needs to update on unique changes.
kara
added
the
action: cleanup
brandonroberts
added
target: patch
brandonroberts
force-pushed
the
forms-overview-copy-edit
branch
from
a852d99
to
d610de0
Compare
|
You can preview d610de0 at https://pr26450-d610de0.ngbuilds.io/. |
|
You can preview 0147659 at https://pr26450-0147659.ngbuilds.io/. |
brandonroberts
removed
the
action: cleanup
|
You can preview 048c013 at https://pr26450-048c013.ngbuilds.io/. |
jenniferfell
approved these changes
Oct 19, 2018
brandonroberts
force-pushed
the
forms-overview-copy-edit
branch
from
048c013
to
536bc37
Compare
|
You can preview 536bc37 at https://pr26450-536bc37.ngbuilds.io/. |
brandonroberts
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Oct 19, 2018
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information