test(ivy): enable unit tests for @angular/animations #26470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
added
area: build & ci
|
You can preview de4d0a3 at https://pr26470-de4d0a3.ngbuilds.io/. |
|
@alxhub is it really expected that we add tags to all of these targets? I think we should do the reverse - tag targets as "ivy-jit-todo" and "ivy-aot-todo". |
|
You can preview 80e9b42 at https://pr26470-80e9b42.ngbuilds.io/. |
|
You can preview 5d04864 at https://pr26470-5d04864.ngbuilds.io/. |
matsko
suggested changes
Oct 17, 2018
matsko
approved these changes
Oct 17, 2018
|
the other two are fixups |
IgorMinar
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Oct 18, 2018
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out that we didn't even have test targets setup for @angular/animations....