Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cli related fixes #26497

Closed
wants to merge 6 commits into from
Closed

docs: cli related fixes #26497

wants to merge 6 commits into from

Conversation

alan-agius4
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

back tick is breaking the links

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@alan-agius4 alan-agius4 changed the title docs: remove extra back tick docs: cli relates fixes Oct 17, 2018
@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview target: patch This PR is targeted for the next patch release labels Oct 17, 2018
@mary-poppins
Copy link

You can preview da8227d at https://pr26497-da8227d.ngbuilds.io/.
You can preview 7184a86 at https://pr26497-7184a86.ngbuilds.io/.
You can preview 3b87c76 at https://pr26497-3b87c76.ngbuilds.io/.
You can preview 008ee1a at https://pr26497-008ee1a.ngbuilds.io/.

@gkalpak gkalpak changed the title docs: cli relates fixes docs: cli related fixes Oct 17, 2018
@mary-poppins
Copy link

You can preview 194e0ed at https://pr26497-194e0ed.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 71d12de at https://pr26497-71d12de.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1271aa7 at https://pr26497-1271aa7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c50f17f at https://pr26497-c50f17f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview eb987b1 at https://pr26497-eb987b1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview dd9f60b at https://pr26497-dd9f60b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ba3633b at https://pr26497-ba3633b.ngbuilds.io/.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@mary-poppins
Copy link

You can preview 02f141c at https://pr26497-02f141c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 44d0f8f at https://pr26497-44d0f8f.ngbuilds.io/.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 17, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
@mhevery mhevery closed this in 638aaec Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 17, 2018
@alan-agius4 alan-agius4 deleted the docs_cli branch October 17, 2018 18:33
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants