feat(docs-infra): update to @angular/* v7 #26555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 0496ac2 at https://pr26555-0496ac2.ngbuilds.io/. |
gkalpak
approved these changes
Oct 18, 2018
aio/package.json
Outdated
| @@ -94,10 +94,10 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@angular-devkit/build-angular": "~0.9.0-rc.1", | |||
There was a problem hiding this comment.
uh... good question. is this related to angular/angular-cli#12624 ?
|
caretaker note: ci flake |
IgorMinar
added
action: merge
IgorMinar
removed
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
This dependency has not been correctly updated and I had to update it manually. I think the issue is related to angular/angular-cli#12624 which was fixed between CLI RCs and final.
|
You can preview 9631b3a at https://pr26555-9631b3a.ngbuilds.io/. |
IgorMinar
added
the
merge: caretaker note
|
ci flaked |
gkalpak
reviewed
Oct 19, 2018
| @@ -93,7 +93,7 @@ | |||
| "zone.js": "^0.8.26" | |||
| }, | |||
| "devDependencies": { | |||
| "@angular-devkit/build-angular": "~0.9.0-rc.1", | |||
| "@angular-devkit/build-angular": "~0.10.0", | |||
alxhub
pushed a commit
that referenced
this pull request
Oct 19, 2018
…#26555) This dependency has not been correctly updated and I had to update it manually. I think the issue is related to angular/angular-cli#12624 which was fixed between CLI RCs and final. PR Close #26555
alxhub
pushed a commit
that referenced
this pull request
Oct 19, 2018
alxhub
pushed a commit
that referenced
this pull request
Oct 19, 2018
…#26555) This dependency has not been correctly updated and I had to update it manually. I think the issue is related to angular/angular-cli#12624 which was fixed between CLI RCs and final. PR Close #26555
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…angular#26555) This dependency has not been correctly updated and I had to update it manually. I think the issue is related to angular/angular-cli#12624 which was fixed between CLI RCs and final. PR Close angular#26555
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…angular#26555) This dependency has not been correctly updated and I had to update it manually. I think the issue is related to angular/angular-cli#12624 which was fixed between CLI RCs and final. PR Close angular#26555
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.