Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code examples style in build doc #26573

Closed
wants to merge 1 commit into from
Closed

docs: fix code examples style in build doc #26573

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Code examples style is not consistent

What is the new behavior?

fix code examples styles

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview target: patch This PR is targeted for the next patch release labels Oct 19, 2018
@mary-poppins
Copy link

You can preview 7fa67e8 at https://pr26573-7fa67e8.ngbuilds.io/.

@ngbot ngbot bot added this to the needsTriage milestone Oct 19, 2018
Copy link
Contributor

@jenniferfell jenniferfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding these and submitting fixes. A few small requests. Thanks!

aio/content/guide/build.md Outdated Show resolved Hide resolved
aio/content/guide/build.md Outdated Show resolved Hide resolved
aio/content/guide/build.md Outdated Show resolved Hide resolved
@jenniferfell jenniferfell changed the title docs: fix code examples style docs: fix code examples style in build doc Oct 25, 2018
@jenniferfell jenniferfell added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 25, 2018
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Oct 26, 2018

@jenniferfell, thanks for the review. Updated.

@brandonroberts brandonroberts self-assigned this Nov 15, 2018
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low subtype: docs-clarification and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 15, 2018
@brandonroberts
Copy link
Contributor

@alan-agius4 will you rebase this branch so the tests will run again?

@alan-agius4
Copy link
Contributor Author

@brandonroberts, done.

@mary-poppins
Copy link

You can preview 9c1c690 at https://pr26573-9c1c690.ngbuilds.io/.

Copy link
Contributor

@jenniferfell jenniferfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. LGTM

@mhevery mhevery closed this in a4934a7 Nov 16, 2018
mhevery pushed a commit that referenced this pull request Nov 16, 2018
@alan-agius4 alan-agius4 deleted the docs_build branch November 16, 2018 20:35
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants