Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix code example to ensure consistency in file #26577

Closed
wants to merge 1 commit into from
Closed

docs: fix code example to ensure consistency in file #26577

wants to merge 1 commit into from

Conversation

preethamvishy
Copy link
Contributor

@preethamvishy preethamvishy commented Oct 19, 2018 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ngbot ngbot bot added this to the needsTriage milestone Dec 20, 2018
@brandonroberts brandonroberts self-assigned this Dec 21, 2018
@brandonroberts brandonroberts added effort1: hours action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Dec 21, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 21, 2018
@mary-poppins
Copy link

You can preview 27d2f50 at https://pr26577-27d2f50.ngbuilds.io/.

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 21, 2018
@matsko matsko closed this in c5ce4e6 Dec 21, 2018
matsko pushed a commit that referenced this pull request Dec 21, 2018
@preethamvishy @matsko
docs: fix code example to ensure consistency in file (#26577)
0ae1e93 
PR Close #26577
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@preethamvishy @ngfelixl
docs: fix code example to ensure consistency in file (angular#26577)
06b2734 
PR Close angular#26577
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees

@brandonroberts brandonroberts

Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@preethamvishy @mary-poppins @brandonroberts @matsko @googlebot