fix(ivy): update largetable benchmark to use ngFor #26604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
action: review
mhevery
approved these changes
Oct 19, 2018
kara
force-pushed
the
largetable
branch
2 times, most recently
from
a91344b
to
a4cdf1e
Compare
kara
removed
the
action: review
kara
force-pushed
the
largetable
branch
2 times, most recently
from
e3b79a7
to
5484a98
Compare
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our render3 largetable benchmark. Previously, it was just using handwritten generated code and an inline ngFor. Now it has the compiler generate the code and uses ngFor.
Notes: