Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename "internal" access modifier to "protected" in AOT compilation guide #26627

Closed
wants to merge 1 commit into from

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Oct 20, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

aot-compiler.md mentions the following: "You cannot make an @input() property private or internal." There is no "internal" access modifier in TypeScript.

Issue Number: N/A

What is the new behavior?

Rename "internal" modifier to "protected"

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gbamparop
Copy link
Contributor Author

I signed the cla!

@googlebot
Copy link

CLAs look good, thanks!

@gbamparop gbamparop closed this Oct 20, 2018
@gbamparop gbamparop reopened this Oct 20, 2018
@brandonroberts brandonroberts self-assigned this Nov 8, 2018
@brandonroberts brandonroberts added type: bug/fix comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 8, 2018
@ngbot ngbot bot modified the milestone: Backlog Nov 8, 2018
@gbamparop gbamparop requested a review from a team as a code owner January 14, 2019 16:49
@brandonroberts brandonroberts changed the title docs: rename "internal" access modifier to "protected" docs: rename "internal" access modifier to "protected" in AOT compilation guide Jan 14, 2019
@brandonroberts brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 14, 2019
@brandonroberts brandonroberts removed the request for review from jenniferfell January 14, 2019 16:51
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2019
@brandonroberts brandonroberts added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 22, 2019
@alxhub alxhub closed this in 197676a Jan 22, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Jan 29, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Jan 30, 2019
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 4, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 5, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 11, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 19, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 22, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 25, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Mar 5, 2019
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Mar 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants