Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits and corrections to cli intro #26654

Closed
wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jbogarthyde jbogarthyde added type: bug/fix comp: docs effort1: hours target: patch This PR is targeted for the next patch release labels Oct 22, 2018
@jbogarthyde jbogarthyde added this to the v7.0 milestone Oct 22, 2018
@mary-poppins
Copy link

You can preview 10db905 at https://pr26654-10db905.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6a094d2 at https://pr26654-6a094d2.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-cli-intro-edit branch 2 times, most recently from b69d028 to ac3be0d Compare October 30, 2018 15:21
@mary-poppins
Copy link

You can preview ac3be0d at https://pr26654-ac3be0d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 628bbeb at https://pr26654-628bbeb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8013db5 at https://pr26654-8013db5.ngbuilds.io/.

Copy link
Contributor

@jenniferfell jenniferfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might need to rebase, because I think another PR also addressed the duplication of ng serve info that was in the original.

@mary-poppins
Copy link

You can preview 7877481 at https://pr26654-7877481.ngbuilds.io/.

@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
@kara kara closed this in 516af6c Nov 2, 2018
@jbogarthyde jbogarthyde deleted the jb-cli-intro-edit branch November 2, 2018 20:53
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants