New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI API docs: do not auto link code blocks #26675
Closed
petebacondarwin
wants to merge
2
commits into
angular:master
from
petebacondarwin:aio-cli-auto-links
Closed
CLI API docs: do not auto link code blocks #26675
petebacondarwin
wants to merge
2
commits into
angular:master
from
petebacondarwin:aio-cli-auto-links
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now mark `<code>` blocks with a `no-auto-link` css class to tell the code auto-linker to ignore this code block.
Some of the text in CLI API docs were being auto-linked to API pages. This was not correct, and in fact these blocks should not have any auto links to Angular API at all. Closes angular#26570
petebacondarwin
added
type: bug/fix
action: review
The PR is still awaiting reviews from at least one requested reviewer
effort1: hours
hotlist: angular-core-team
freq2: medium
target: patch
This PR is targeted for the next patch release
risk: low
labels
Oct 23, 2018
You can preview 383fcf0 at https://pr26675-383fcf0.ngbuilds.io/. |
gkalpak
approved these changes
Oct 23, 2018
petebacondarwin
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Oct 23, 2018
matsko
pushed a commit
that referenced
this pull request
Oct 26, 2018
You can now mark `<code>` blocks with a `no-auto-link` css class to tell the code auto-linker to ignore this code block. PR Close #26675
matsko
pushed a commit
that referenced
this pull request
Oct 26, 2018
matsko
pushed a commit
that referenced
this pull request
Oct 26, 2018
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…26675) You can now mark `<code>` blocks with a `no-auto-link` css class to tell the code auto-linker to ignore this code block. PR Close angular#26675
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…ngular#26675) Some of the text in CLI API docs were being auto-linked to API pages. This was not correct, and in fact these blocks should not have any auto links to Angular API at all. Closes angular#26570 PR Close angular#26675
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…26675) You can now mark `<code>` blocks with a `no-auto-link` css class to tell the code auto-linker to ignore this code block. PR Close angular#26675
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…ngular#26675) Some of the text in CLI API docs were being auto-linked to API pages. This was not correct, and in fact these blocks should not have any auto links to Angular API at all. Closes angular#26570 PR Close angular#26675
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
effort1: hours
freq2: medium
risk: low
target: patch
This PR is targeted for the next patch release
type: bug/fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26570