Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI API docs: do not auto link code blocks #26675

Closed

Conversation

petebacondarwin
Copy link
Member

Closes #26570

You can now mark `<code>` blocks with a `no-auto-link` css class
to tell the code auto-linker to ignore this code block.
Some of the text in CLI API docs were being auto-linked to API
pages. This was not correct, and in fact these blocks should not
have any auto links to Angular API at all.

Closes angular#26570
@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours hotlist: angular-core-team freq2: medium target: patch This PR is targeted for the next patch release risk: low labels Oct 23, 2018
@petebacondarwin petebacondarwin added this to the Backlog milestone Oct 23, 2018
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Oct 23, 2018
@mary-poppins
Copy link

You can preview 383fcf0 at https://pr26675-383fcf0.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2018
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Oct 23, 2018
matsko pushed a commit that referenced this pull request Oct 26, 2018
You can now mark `<code>` blocks with a `no-auto-link` css class
to tell the code auto-linker to ignore this code block.

PR Close #26675
matsko pushed a commit that referenced this pull request Oct 26, 2018
…26675)

Some of the text in CLI API docs were being auto-linked to API
pages. This was not correct, and in fact these blocks should not
have any auto links to Angular API at all.

Closes #26570

PR Close #26675
@matsko matsko closed this in 9ff8155 Oct 26, 2018
matsko pushed a commit that referenced this pull request Oct 26, 2018
…26675)

Some of the text in CLI API docs were being auto-linked to API
pages. This was not correct, and in fact these blocks should not
have any auto links to Angular API at all.

Closes #26570

PR Close #26675
@petebacondarwin petebacondarwin deleted the aio-cli-auto-links branch October 27, 2018 08:56
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
…26675)

You can now mark `<code>` blocks with a `no-auto-link` css class
to tell the code auto-linker to ignore this code block.

PR Close angular#26675
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
…ngular#26675)

Some of the text in CLI API docs were being auto-linked to API
pages. This was not correct, and in fact these blocks should not
have any auto links to Angular API at all.

Closes angular#26570

PR Close angular#26675
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
…26675)

You can now mark `<code>` blocks with a `no-auto-link` css class
to tell the code auto-linker to ignore this code block.

PR Close angular#26675
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
…ngular#26675)

Some of the text in CLI API docs were being auto-linked to API
pages. This was not correct, and in fact these blocks should not
have any auto links to Angular API at all.

Closes angular#26570

PR Close angular#26675
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq2: medium risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
Development

Successfully merging this pull request may close these issues.

docs: CLI command arguments are automatically being linked to API docs
4 participants