Ivy/rename local flag to aot #26686
Closed
Ivy/rename local flag to aot #26686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
added
area: build & ci
IgorMinar
force-pushed
the
ivy/rename-local-flag-to-aot
branch
from
2073997
to
7ad5bde
Compare
|
You can preview 2073997 at https://pr26686-2073997.ngbuilds.io/. |
|
You can preview 7ad5bde at https://pr26686-7ad5bde.ngbuilds.io/. |
mhevery
approved these changes
Oct 23, 2018
mhevery
approved these changes
Oct 23, 2018
IgorMinar
force-pushed
the
ivy/rename-local-flag-to-aot
branch
from
7ad5bde
to
c870b3d
Compare
IgorMinar
added
action: merge
…xme-ivy-aot yarn scripts
IgorMinar
force-pushed
the
ivy/rename-local-flag-to-aot
branch
from
c870b3d
to
9525626
Compare
IgorMinar
force-pushed
the
ivy/rename-local-flag-to-aot
branch
from
9525626
to
08d26aa
Compare
IgorMinar
added a commit
that referenced
this pull request
Oct 23, 2018
alxhub
pushed a commit
that referenced
this pull request
Oct 23, 2018
alexeagle
reviewed
Oct 24, 2018
| @@ -25,7 +25,11 @@ | |||
| "postinstall": "yarn update-webdriver && node ./tools/postinstall-patches.js", | |||
| "update-webdriver": "webdriver-manager update --gecko false $CHROMEDRIVER_VERSION_ARG", | |||
| "check-env": "gulp check-env", | |||
| "commitmsg": "node ./scripts/git/commit-msg.js" | |||
| "commitmsg": "node ./scripts/git/commit-msg.js", | |||
| "test-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=ivy-jit --test_tag_filters=ivy-jit", | |||
There was a problem hiding this comment.
I'm surprised this doesn't include the //... pattern as well
|
Given the number of failing targets these scripts are meant to enable you
to run a particular failing target or a group of targets.
…On Wed, Oct 24, 2018, 3:45 PM Paul Gschwendtner ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#26686 (comment)>:
> @@ -25,7 +25,11 @@
"postinstall": "yarn update-webdriver && node ./tools/postinstall-patches.js",
"update-webdriver": "webdriver-manager update --gecko false $CHROMEDRIVER_VERSION_ARG",
"check-env": "gulp check-env",
- "commitmsg": "node ./scripts/git/commit-msg.js"
+ "commitmsg": "node ./scripts/git/commit-msg.js",
+ "test-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=ivy-jit --test_tag_filters=ivy-jit",
Yeah I just assumed that the given Bazel flags are the key point of the
NPM script.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#26686 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANM6MVZoTNY8nvoi5hRTGRHkIQMHmK2ks5uoG8CgaJpZM4X2C2q>
.
|
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…xme-ivy-aot yarn scripts (angular#26686) PR Close angular#26686
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…xme-ivy-aot yarn scripts (angular#26686) PR Close angular#26686
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.