ci: only publish builds if relevant aio jobs pass
#26722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the `aio`-/`docs`-related jobs rely on the locally built Angular packages. When these jobs fail, it could mean that there is an issue with the Angular packages (e.g. an unintentional breaking change). This commit ensures that the `publish_artifacts` job is not run, unless those `aio`-/`docs`-related jobs pass. (The `test_aio_tools` job also uses the locally built Angular packages, but it does not exercise them in a meaningful way to be worth making it a prerequisite for `publish_artifacts`.)
gkalpak
added
area: build & ci
alexeagle
approved these changes
Oct 24, 2018
gkalpak
added
action: merge
matsko
pushed a commit
that referenced
this pull request
Oct 24, 2018
Some of the `aio`-/`docs`-related jobs rely on the locally built Angular packages. When these jobs fail, it could mean that there is an issue with the Angular packages (e.g. an unintentional breaking change). This commit ensures that the `publish_artifacts` job is not run, unless those `aio`-/`docs`-related jobs pass. (The `test_aio_tools` job also uses the locally built Angular packages, but it does not exercise them in a meaningful way to be worth making it a prerequisite for `publish_artifacts`.) PR Close #26722
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
Some of the `aio`-/`docs`-related jobs rely on the locally built Angular packages. When these jobs fail, it could mean that there is an issue with the Angular packages (e.g. an unintentional breaking change). This commit ensures that the `publish_artifacts` job is not run, unless those `aio`-/`docs`-related jobs pass. (The `test_aio_tools` job also uses the locally built Angular packages, but it does not exercise them in a meaningful way to be worth making it a prerequisite for `publish_artifacts`.) PR Close angular#26722
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
Some of the `aio`-/`docs`-related jobs rely on the locally built Angular packages. When these jobs fail, it could mean that there is an issue with the Angular packages (e.g. an unintentional breaking change). This commit ensures that the `publish_artifacts` job is not run, unless those `aio`-/`docs`-related jobs pass. (The `test_aio_tools` job also uses the locally built Angular packages, but it does not exercise them in a meaningful way to be worth making it a prerequisite for `publish_artifacts`.) PR Close angular#26722
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
Some of the
aio-/docs-related jobs rely on the locally built Angular packages. When these jobs fail, it could mean that there is an issue with the Angular packages (e.g. an unintentional breaking change).The
publish_artifactsjob ignores such failures and runs anyway.Issue Number: N/A
What is the new behavior?
The
publish_artifactsjob is not run, unless thoseaio-/docs-related jobs pass.Does this PR introduce a breaking change?
Other information
(The
test_aio_toolsjob also uses the locally built Angular packages, but it does not exercise them in a meaningful way to be worth making it a prerequisite forpublish_artifacts.)