New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bazel): fix //modules/benchmarks/src/largetable/render3:perf benchmark in CI #26908
Conversation
You can preview 9e69abb at https://pr26908-9e69abb.ngbuilds.io/. |
You can preview 124973e at https://pr26908-124973e.ngbuilds.io/. |
You can preview 599b5ef at https://pr26908-599b5ef.ngbuilds.io/. |
You can preview 426bd23 at https://pr26908-426bd23.ngbuilds.io/. |
You can preview 816b377 at https://pr26908-816b377.ngbuilds.io/. |
076b696
to
16da469
Compare
16da469
to
115c8aa
Compare
115c8aa
to
b265161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we can't switch to the other rule that brings in its own browsers? The fewer exceptions and customizations we make to this setup the easier it is to maintain it. But maybe there is a valid reason and in that case we should document it in the circle ci config where we pull in the custom docker image.
You can preview 038ffe3 at https://pr26908-038ffe3.ngbuilds.io/. |
c616276
to
875653d
Compare
You can preview bfbe09d at https://pr26908-bfbe09d.ngbuilds.io/. |
You can preview 875653d at https://pr26908-875653d.ngbuilds.io/. |
875653d
to
99732ae
Compare
…without local chrome
99732ae
to
ddd35bc
Compare
You can preview 99732ae at https://pr26908-99732ae.ngbuilds.io/. |
You can preview ddd35bc at https://pr26908-ddd35bc.ngbuilds.io/. |
Updated to use protractor_web_test_suite so that chrome is not needed locally anymore. It needed an update to the protractor rule to merge capabilities but looks like it works like a charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…without local chrome (angular#26908) PR Close angular#26908
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Underlying issue was that
//modules/benchmarks/src/largetable/render3:perf
relies on the locally installed version of chrome. It usesprotractor_web_test
and notprotractor_web_test_suite
. The latter provides its own version of chrome viarules_webtesting
, the former does not.To fix it, the
browsers_docker_image
docker image is now used fortest_ivy_aot
andtest_ivy_jit
and the benchmark is also run locally and not on RBE.