Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: new GitHub Issue templates #26918

Closed
wants to merge 1 commit into from
Closed

docs: new GitHub Issue templates #26918

wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

These templates take advatange of github's feature that allows
us to define multiple templates and which the UI presents to the
user and lets them choose the most appropriate template.

The goal of this is to tailor the templates to the templates to
various use-cases and bug categories and provide better guidance to
developers filing issues which should result in more efficient
processing of the issue backlog.

You can view the demo of this change at: https://github.com/IgorMinar/angular/issues/new/choose

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2018
kara
kara approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some typos

.github/ISSUE_TEMPLATE/1-bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/7-angular-material.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/6-angular-cli.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/5-support-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/3-docs-bug.md Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 2, 2018
@kara
Copy link
Contributor

kara commented Nov 2, 2018

@IgorMinar Apply merge label when ready

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 5, 2018
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker cla: yes and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: no labels Nov 5, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@IgorMinar IgorMinar removed the request for review from mhevery November 5, 2018 00:09
@IgorMinar
Copy link
Contributor Author

@kara thanks for all the fixes!!

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 5, 2018
@IgorMinar
Copy link
Contributor Author

caretaker note: this pr has no impact on ci except for the lint job, so the failures are unrelated.

@IgorMinar
docs: new GitHub Issue templates
abc40fb 
These templates take advatange of github's feature that allows
us to define multiple templates and which the UI presents to the
user and lets them choose the most appropriate template.

The goal of this is to tailor the templates to the templates to
various use-cases and bug categories and provide better guidance to
developers filing issues which should result in more efficient
processing of the issue backlog.
@googlebot
Copy link

CLAs look good, thanks!

@IgorMinar IgorMinar removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 5, 2018
@brandonroberts brandonroberts mentioned this pull request Nov 5, 2018
Closed
14 tasks
@kara kara closed this in 86d41a1 Nov 5, 2018
kara pushed a commit that referenced this pull request Nov 5, 2018
@IgorMinar @kara
docs: new GitHub Issue templates (#26918)
352219e 
These templates take advatange of github's feature that allows
us to define multiple templates and which the UI presents to the
user and lets them choose the most appropriate template.

The goal of this is to tailor the templates to the templates to
various use-cases and bug categories and provide better guidance to
developers filing issues which should result in more efficient
processing of the issue backlog.

PR Close #26918
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@IgorMinar @FrederikSchlemmer
docs: new GitHub Issue templates (angular#26918)
a302ad4 
These templates take advatange of github's feature that allows
us to define multiple templates and which the UI presents to the
user and lets them choose the most appropriate template.

The goal of this is to tailor the templates to the templates to
various use-cases and bug categories and provide better guidance to
developers filing issues which should result in more efficient
processing of the issue backlog.

PR Close angular#26918
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees

@IgorMinar IgorMinar

Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IgorMinar @kara @googlebot