Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): run forms tests with ivy on ci #26968

Closed
wants to merge 1 commit into from
Closed

test(ivy): run forms tests with ivy on ci #26968

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Nov 6, 2018

This PR turns on forms tests with Ivy on CI. Remaining test failures under investigation are prefixed with fixmeIvy and the reason for failure.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Nov 6, 2018
@kara kara requested a review from mhevery November 6, 2018 22:05
@ngbot ngbot bot added this to the needsTriage milestone Nov 6, 2018
@mary-poppins
Copy link

You can preview 66469a4 at https://pr26968-66469a4.ngbuilds.io/.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 6, 2018
@kara kara closed this in 3ca1a57 Nov 6, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@kara @FrederikSchlemmer
test(ivy): run forms tests with ivy on ci (angular#26968)
a4ce94e 
PR Close angular#26968
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kara @mary-poppins @mhevery @googlebot