Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(forms): update description for FormBuilder.group #26970

Closed
wants to merge 2 commits into from
Closed

docs(forms): update description for FormBuilder.group #26970

wants to merge 2 commits into from

Conversation

kara
Copy link
Contributor

@kara kara commented Nov 6, 2018

This PR simply adds some more documentation for the FormBuilder.group method.

@kara kara added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer area: forms labels Nov 6, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 6, 2018
@kara kara added the target: major This PR is targeted for the next major release label Nov 6, 2018
@mary-poppins
Copy link

You can preview 9b3ba97 at https://pr26970-9b3ba97.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I suggested some improvements

packages/forms/src/form_builder.ts Outdated Show resolved Hide resolved
packages/forms/src/form_builder.ts Outdated Show resolved Hide resolved
packages/forms/src/form_builder.ts Outdated Show resolved Hide resolved
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 7, 2018
@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 7, 2018
@kara kara closed this in a4398aa Nov 7, 2018
@cexbrayat
Copy link
Member

@kara Sorry to comment here, but couldn't the API be more type safe like:

legacyOrOpts: AbstractControlOptions|{[key: string]: any}|null

It would be more explanatory no? Would that break something or is it worth a PR?

@cexbrayat
Copy link
Member

@kara I was intrigued and submitted #26985

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@kara @FrederikSchlemmer
docs(forms): update description for FormBuilder.group (angular#26970)
8fa24ba 
PR Close angular#26970
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@bradlygreen bradlygreen Awaiting requested review from bradlygreen

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kara @mary-poppins @cexbrayat @IgorMinar @googlebot