Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global utils to api guardian #27008

Closed
wants to merge 3 commits into from
Closed

add global utils to api guardian #27008

wants to merge 3 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@IgorMinar IgorMinar requested a review from matsko November 8, 2018 17:30
@IgorMinar IgorMinar added cla: yes and removed cla: no labels Nov 8, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@IgorMinar IgorMinar force-pushed the ci/add-global-utils-to-api-guardian branch from 49137e6 to a7a57d2 Compare November 8, 2018 17:32
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 8, 2018
@IgorMinar IgorMinar added cla: yes and removed cla: no labels Nov 8, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Nov 8, 2018
@IgorMinar IgorMinar mentioned this pull request Nov 8, 2018
Closed
@mary-poppins
Copy link

You can preview 49137e6 at https://pr27008-49137e6.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the ci/add-global-utils-to-api-guardian branch from a7a57d2 to 4ecc604 Compare November 8, 2018 17:36
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 8, 2018
@IgorMinar IgorMinar added cla: yes and removed cla: no labels Nov 8, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@IgorMinar
test(ivy): add global utils to the public_api_guard test
4ba7aca 
This API is part of our public api surface and needs to be monitored by the public_api_guard.

I also had to go back and mark all of the exported functions with @publicapi jsdoc tag.
@mary-poppins
Copy link

You can preview 4ecc604 at https://pr27008-4ecc604.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the ci/add-global-utils-to-api-guardian branch from 4ecc604 to 4ba7aca Compare November 8, 2018 17:40
@googlebot googlebot added cla: no and removed cla: yes labels Nov 8, 2018
@IgorMinar IgorMinar added cla: yes and removed cla: no labels Nov 8, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mary-poppins
Copy link

You can preview 4ba7aca at https://pr27008-4ba7aca.ngbuilds.io/.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 8, 2018
@AndrewKushnir
Copy link
Contributor

@IgorMinar it looks like lint tests fail - could you plz update PR before I merge?

@googlebot googlebot added cla: no and removed cla: yes labels Nov 8, 2018
@AndrewKushnir
Copy link
Contributor

@IgorMinar @matsko I've updated this PR to resolve the lint issue. Could you please have a quick look to make sure everything is fine before I merge (and change the label back to "PR action: merge" as needed)? Thank you.

@mary-poppins
Copy link

You can preview 20bb87a at https://pr27008-20bb87a.ngbuilds.io/.

@angular angular deleted a comment from googlebot Nov 8, 2018
@angular angular deleted a comment from googlebot Nov 8, 2018
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker cla: yes and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: no labels Nov 8, 2018
@IgorMinar
Copy link
Contributor Author

@AndrewKushnir thanks!

btw I kicked off a presubmit but this change is unlikely to cause issues in g3 if external CI is passing.

http://test/OCL:220698464:BASE:220698535:1541714823276:417401a5

AndrewKushnir pushed a commit that referenced this pull request Nov 8, 2018
@IgorMinar @AndrewKushnir
test(ivy): add global utils to the public_api_guard test (#27008)
499e303 
This API is part of our public api surface and needs to be monitored by the public_api_guard.

I also had to go back and mark all of the exported functions with @publicapi jsdoc tag.

PR Close #27008
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@matsko @FrederikSchlemmer
feat(ivy): introduce getPlayers() to global utils (angular#27008)
b00f881 
PR Close angular#27008
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@IgorMinar @FrederikSchlemmer
test(ivy): add global utils to the public_api_guard test (angular#27008)
85b56e5 
This API is part of our public api surface and needs to be monitored by the public_api_guard.

I also had to go back and mark all of the exported functions with @publicapi jsdoc tag.

PR Close angular#27008
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsko matsko matsko approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @googlebot @mary-poppins @AndrewKushnir @matsko