refactor(ivy): abstract all styling-related compiler logic into a shared class #27043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 98d3dba at https://pr27043-98d3dba.ngbuilds.io/. |
alfaproject
reviewed
Nov 10, 2018
| case 'list-style-image': | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This minifies better and I think it's more performant too:
return prop === 'background-image'
|| prop === 'background'
|| prop === 'border-image'
|| prop === 'filter'
|| prop === 'filter'
|| prop === 'list-style'
|| prop === 'list-style-image';P.S.: If you don't use triple equals it minifies even better. You can safely ignore any linting rule just for this block.
There was a problem hiding this comment.
Excellent. Thank you.
alfaproject
reviewed
Nov 11, 2018
| }).toLowerCase(); | ||
| function isStyleSanitizable(prop: string): boolean { | ||
| return prop === 'background-image' || prop === 'background' || prop === 'border-image' || | ||
| prop === 'filter' || prop === 'filter' || prop === 'list-style' || |
There was a problem hiding this comment.
filter check is repeated
|
You can preview 0ff832d at https://pr27043-0ff832d.ngbuilds.io/. |
mhevery
approved these changes
Nov 12, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.