set encapsulation to None when there is no style / set ng-version attribute on root component
#27175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
type: bug/fix
action: review
alxhub
approved these changes
Nov 19, 2018
|
You can preview 4cf11f8 at https://pr27175-4cf11f8.ngbuilds.io/. |
mhevery
approved these changes
Nov 19, 2018
ocombe
force-pushed
the
fix/ivy/testbed-platform-server/render
branch
from
4cf11f8
to
e2bb32f
Compare
|
You can preview e2bb32f at https://pr27175-e2bb32f.ngbuilds.io/. |
alxhub
approved these changes
Nov 20, 2018
ocombe
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Nov 20, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We used to set view encapsulation to
Nonewhen there was no styles, but it's not the case with ivy, which will create css attribute selectors on elements when it's not needed.Also we don't set the
ng-versionattribute on the root component.What is the new behavior?
We set encapsulation to
Nonewhen there is no style.We set
ng-versionattribute on root component.Does this PR introduce a breaking change?