Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): hack implementation of host styles #27180

Closed
wants to merge 4 commits into from
Closed

fix(ivy): hack implementation of host styles #27180

wants to merge 4 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Nov 19, 2018

No description provided.

@mhevery mhevery requested a review from kara November 19, 2018 22:56
@mary-poppins
Copy link

You can preview a17e80c at https://pr27180-a17e80c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9d1adb7 at https://pr27180-9d1adb7.ngbuilds.io/.

kara
kara approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nits below

packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
@kara kara added target: major This PR is targeted for the next major release comp: ivy labels Nov 20, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 20, 2018
@kara kara added type: bug/fix area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 20, 2018
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 20, 2018
@mary-poppins
Copy link

You can preview f4e886f at https://pr27180-f4e886f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 01fec84 at https://pr27180-01fec84.ngbuilds.io/.

@mhevery mhevery closed this in ca40565 Nov 20, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@mhevery @FrederikSchlemmer
fix(ivy): hack implementation of host styles (angular#27180)
ba41205 
PR Close angular#27180
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@mhevery @ngfelixl
fix(ivy): hack implementation of host styles (angular#27180)
1503493 
PR Close angular#27180
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@kara kara kara approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhevery @mary-poppins @alfaproject @kara @googlebot