build: update yarn version #27193
build: update yarn version #27193
Conversation
|
Can you lock yarn version to 1.12.x in package.json to avoid this kind of errors in the future? |
alexeagle
force-pushed
the
update_yarn
branch
from
c1ef7f3
to
bc498c6
Compare
|
Sounds good, once the tests pass |
There was a problem hiding this comment.
Where does yarn that is installed on circleci come from? based on the CI errors we run 1.10.x on circle, which causes CI to fail.
In the past it came from the docker image but now I don't see where it's installed. Do we rely on yarn being provided by the default docker image? that seems wrong.
IgorMinar
added
action: cleanup
alexeagle
force-pushed
the
update_yarn
branch
from
bc498c6
to
baf3c7a
Compare
|
You can preview baf3c7a at https://pr27193-baf3c7a.ngbuilds.io/. |
alexeagle
force-pushed
the
update_yarn
branch
from
baf3c7a
to
cd120c7
Compare
|
@IgorMinar yes we pick up a yarn version from docker circleci/node:10.12 (which is already 1.10.1) |
|
You can preview cd120c7 at https://pr27193-cd120c7.ngbuilds.io/. |
|
how about we add an additional step to our CI jobs that will install the exact version of yarn based on the variable set in https://github.com/angular/angular/blob/master/.circleci/env.sh ? |
|
sounds great but I think we should merge this to fix the breakage and do a fancier setup later |
Some engineers were already on Yarn 0.10.x which was permitted by the range in our package.json#engines However this introduced 'integrity sha512' lines into the yarn.lock files. Then when engineers use yarn 0.9 (in particular, Bazel did this) then the lock files get tons of meaningless edits. We could force everyone back to yarn 0.9 but this commit chooses to instead advance everyone past 0.10
alexeagle
force-pushed
the
update_yarn
branch
from
cd120c7
to
95ff645
Compare
alexeagle
removed
the
action: cleanup
|
You can preview 95ff645 at https://pr27193-95ff645.ngbuilds.io/. |
|
@IgorMinar this commit also updates to latest rules_nodejs, where Bazel will no longer touch your lock file. |
|
Awesome! Thanks
…On Tue, Nov 20, 2018, 1:08 PM Alex Eagle ***@***.*** wrote:
@IgorMinar <https://github.com/IgorMinar> this commit also updates to
latest rules_nodejs, where Bazel will no longer touch your lock file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27193 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6FNfIVi2qa4eFXFBe2RULy1N_U6sks5uxG9bgaJpZM4YrNTP>
.
|
Some engineers were already on Yarn 0.10.x which was permitted by the range in our package.json#engines However this introduced 'integrity sha512' lines into the yarn.lock files. Then when engineers use yarn 0.9 (in particular, Bazel did this) then the lock files get tons of meaningless edits. We could force everyone back to yarn 0.9 but this commit chooses to instead advance everyone past 0.10 PR Close #27193
Some engineers were already on Yarn 0.10.x which was permitted by the range in our package.json#engines However this introduced 'integrity sha512' lines into the yarn.lock files. Then when engineers use yarn 0.9 (in particular, Bazel did this) then the lock files get tons of meaningless edits. We could force everyone back to yarn 0.9 but this commit chooses to instead advance everyone past 0.10 PR Close angular#27193
Some engineers were already on Yarn 0.10.x which was permitted by the range in our package.json#engines However this introduced 'integrity sha512' lines into the yarn.lock files. Then when engineers use yarn 0.9 (in particular, Bazel did this) then the lock files get tons of meaningless edits. We could force everyone back to yarn 0.9 but this commit chooses to instead advance everyone past 0.10 PR Close angular#27193
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some engineers were already on Yarn 0.10.x which was permitted by the range in our package.json#engines
However this introduced 'integrity sha512' lines into the yarn.lock files.
Then when engineers use yarn 0.9 (in particular, Bazel did this) then the lock files get tons of meaningless edits.
We could force everyone back to yarn 0.9 but this commit chooses to instead advance everyone past 0.10