Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): add polyfill for goog.getMsg to unblock tests (FW-663) #27218

Closed
wants to merge 2 commits into from
Closed

fix(ivy): add polyfill for goog.getMsg to unblock tests (FW-663) #27218

wants to merge 2 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

This PR adds goog.getMsg polyfill to let i18n-related tests running correctly outside of Closure Compiler. This polyfill will not be needed once runtime translation service support is added.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Nov 21, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 21, 2018
@mary-poppins
Copy link

You can preview 6b5588a at https://pr27218-6b5588a.ngbuilds.io/.

@AndrewKushnir
Copy link
Contributor Author

Presubmit

@angular angular deleted a comment from mary-poppins Nov 27, 2018
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 28, 2018
@jasonaden jasonaden closed this in 7773d7f Nov 28, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@AndrewKushnir @FrederikSchlemmer
fix(ivy): add polyfill for goog.getMsg to unblock tests (FW-663) (ang…
95ba1e7 
…ular#27218)

PR Close angular#27218
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@AndrewKushnir @ngfelixl
fix(ivy): add polyfill for goog.getMsg to unblock tests (FW-663) (ang…
0e72b37 
…ular#27218)

PR Close angular#27218
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments

@mhevery mhevery mhevery approved these changes

@ocombe ocombe ocombe approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndrewKushnir @mary-poppins @mhevery @ocombe @pkozlowski-opensource @googlebot