fix(ivy): inject null for missing attributes #27237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
|
You can preview b07554c at https://pr27237-b07554c.ngbuilds.io/. |
pkozlowski-opensource
force-pushed
the
ivy_non_existing_attr_injection
branch
from
b07554c
to
b15a205
Compare
|
You can preview b15a205 at https://pr27237-b15a205.ngbuilds.io/. |
mhevery
approved these changes
Nov 22, 2018
mhevery
added
action: merge
mhevery
approved these changes
Nov 25, 2018
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix to align ivy's impl with the view engine one. Found while analysing root causes for the existing tests failures.
tl;dr; is that view engine injects
nullwhen injected@Attributeis not found.