-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): proper accounting of bound vars in i18nExp fns (FW-747) #27338
fix(ivy): proper accounting of bound vars in i18nExp fns (FW-747) #27338
Conversation
9f75d07
to
31a62f0
Compare
Please add a more detailed commit message describing what the problem was and how the fix works. |
31a62f0
to
467a599
Compare
CARETAKER: this PR should be rebased and merged after PR #27185 |
The problem was caused by missing `allocateBindingSlots` that led to incorrect # of vars defined for components and as a result, causing errors at runtime. Now all `bind` operation are accounted for and the number of `vars` is correct.
467a599
to
0432eb1
Compare
You can preview 0432eb1 at https://pr27338-0432eb1.ngbuilds.io/. |
…gular#27338) The problem was caused by missing `allocateBindingSlots` that led to incorrect # of vars defined for components and as a result, causing errors at runtime. Now all `bind` operation are accounted for and the number of `vars` is correct. PR Close angular#27338
…gular#27338) The problem was caused by missing `allocateBindingSlots` that led to incorrect # of vars defined for components and as a result, causing errors at runtime. Now all `bind` operation are accounted for and the number of `vars` is correct. PR Close angular#27338
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR adds proper accounting of bound vars (e.g.
bind(ctx.myVar)
) used ini18nExp
instructions. TheallocateBindingSlots
fn invocation was missing that led to incorrect # ofvars
defined for components => errors at runtime.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?