Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move Minko to Angular #27339

Closed
wants to merge 1 commit into from
Closed

docs: move Minko to Angular #27339

wants to merge 1 commit into from

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Nov 29, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

I was part of the GDE group

What is the new behavior?

Moved myself to the Angular team :)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview 6b4ffe4 at https://pr27339-6b4ffe4.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 29, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 29, 2018
@ngbot
Copy link

ngbot bot commented Nov 29, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/push" is failing
    failure status "ci/circleci: test_aio" is failing
    failure status "ci/circleci: test_aio_local" is failing
    failure status "ci/circleci: test_aio_tools" is failing
    failure status "ci/circleci: test_docs_examples_1" is failing
    failure status "ci/circleci: integration_test" is failing
    failure status "ci/circleci: test_docs_examples_0" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak gkalpak removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 29, 2018
@gkalpak
Copy link
Member

gkalpak commented Nov 29, 2018

Hm...the tests were passing (except for integration) one moment ago. Now they are all red :thi

@gkalpak
Copy link
Member

gkalpak commented Nov 29, 2018

Also, please, change the commit message to docs: ....

Joined the team at Google about a month ago ✨
@mgechev mgechev changed the title fix(aio): move Minko to Angular docs: move Minko to Angular Nov 29, 2018
@mgechev
Copy link
Member Author

mgechev commented Nov 29, 2018

Done
Looks like CI is about to welcome me to the team as well 😄

@gkalpak
Copy link
Member

gkalpak commented Nov 29, 2018

😂
I restarted aio_preview; let's see if CircleCI will ping the preview server this time.

@gkalpak
Copy link
Member

gkalpak commented Nov 29, 2018

Nothing 🤷‍♂️

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 29, 2018
@ngbot
Copy link

ngbot bot commented Nov 29, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio_preview" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak
Copy link
Member

gkalpak commented Nov 29, 2018

Note to caretaker: Please ignore the test_aio_preview failure. It is caused by #27352 and is unrelated to this PR.

IgorMinar pushed a commit that referenced this pull request Nov 30, 2018
Joined the team at Google about a month ago ✨

PR Close #27339
@IgorMinar IgorMinar closed this in 2d51579 Nov 30, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
Joined the team at Google about a month ago ✨

PR Close angular#27339
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
Joined the team at Google about a month ago ✨

PR Close angular#27339
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants