Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): update root causes for @angular/core TestBed failures #27370

Conversation

pkozlowski-opensource
Copy link
Member

Another portion of root cause analysis...

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Nov 30, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 30, 2018
@pkozlowski-opensource pkozlowski-opensource added target: major This PR is targeted for the next major release PR action: time-zone labels Nov 30, 2018
@pkozlowski-opensource pkozlowski-opensource force-pushed the ivy_test_bed_integration_spec_remaining_unknonws branch from 01d1975 to 3e1f78d Compare November 30, 2018 16:23
@mary-poppins
Copy link

You can preview 3e1f78d at https://pr27370-3e1f78d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 01d1975 at https://pr27370-01d1975.ngbuilds.io/.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2018
@IgorMinar IgorMinar closed this in 1fa5478 Nov 30, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants